Conversation
Contributor
|
Comparison of Helm chart templating output: @@ data.original-values @@
! ± value change in multiline text (one insert, one deletion)
{
"autoscaleMax": 5,
"autoscaleMin": 1,
"env": {
[77 lines unchanged)]
"x-auth-request-user"
],
"includeRequestHeadersInCheck": [
"authorization",
- "cookie"
+ "cookie",
+ "accept"
],
"port": 80,
"service": "oauth2-proxy.istio-system.svc.cluster.local"
},
[27 lines unchanged)]
}
},
"revision": "1-26-0"
}
@@ data.merged-values @@
! ± value change in multiline text (one insert, one deletion)
{
"affinity": {},
"autoscaleBehavior": {},
"autoscaleEnabled": true,
[206 lines unchanged)]
"x-auth-request-user"
],
"includeRequestHeadersInCheck": [
"authorization",
- "cookie"
+ "cookie",
+ "accept"
],
"port": 80,
"service": "oauth2-proxy.istio-system.svc.cluster.local"
},
[78 lines unchanged)]
"variant": "",
"volumeMounts": [],
"volumes": []
}
@@ data.mesh @@
! ± value change in multiline text (one insert, no deletions)
accessLogFile: /dev/stdout
accessLogFormat: |
[%START_TIME%] "%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)% %PROTOCOL%" %RESPONSE_CODE% %RESPONSE_FLAGS% %RESPONSE_CODE_DETAILS% %CONNECTION_TERMINATION_DETAILS% "%UPSTREAM_TRANSPORT_FAILURE_REASON%" %BYTES_RECEIVED% %BYTES_SENT% %DURATION% %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)% "%REQ(X-FORWARDED-FOR)%" "%REQ(USER-AGENT)%" "%REQ(X-REQUEST-ID)%" "%REQ(:AUTHORITY)%" "%UPSTREAM_HOST%" %UPSTREAM_CLUSTER% %UPSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_REMOTE_ADDRESS% %REQUESTED_SERVER_NAME% %ROUTE_NAME% traceID=%REQ(TRACEPARENT)%
defaultConfig:
[25 lines unchanged)]
- x-auth-request-user
includeRequestHeadersInCheck:
- authorization
- cookie
+ - accept
port: 80
service: oauth2-proxy.istio-system.svc.cluster.local
name: oauth2-proxy-ext-authz
- envoyExtAuthzGrpc:
[seven lines unchanged)]
interval: 5s
probes: 3
time: 10s
trustDomain: cluster.local
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This changes the configuration of the Istio backend interface to OAuth2-Proxy, which is expected to return JSON and not HTML on errors.
🔍 Reviewer Notes
🧹 Checklist