enable SSA tag linter

Author: eljohnson92

.golangci-kal.yml

@@ -18,8 +18,9 @@ linters:
           linters:
             # TODO: remove linters from this list as we add support from them
             disable:
-              - "ssatags"
+              # integers linter will force type change from int to int32/int64, we are going to wait for v1beta1 to enable this
               - "integers"
+              # jsontags linter will force the json fields to go from _ usage to camelCase, we will wait for v1beta1 to enable this
               - "jsontags"
               - "requiredfields"
               - "optionalfields"

api/v1alpha2/firewallrule_types.go

@@ -52,6 +52,7 @@ type FirewallRuleSpec struct {
 	// addressSetRefs is a list of references to AddressSets as an alternative to
 	// using Addresses but can be used in conjunction with it.
 	// +optional
+	// +listType=atomic
 	AddressSetRefs []*corev1.ObjectReference `json:"addressSetRefs,omitempty"`
 }
 

api/v1alpha2/linodecluster_types.go

@@ -213,6 +213,8 @@ type NetworkSpec struct {
 
 	// additionalPorts contains list of ports to be configured with NodeBalancer.
 	// +optional
+	// +listType=map
+	// +listMapKey=port
 	AdditionalPorts []LinodeNBPortConfig `json:"additionalPorts,omitempty"`
 
 	// subnetName is the name/label of the VPC subnet to be used by the cluster

api/v1alpha2/linodefirewall_types.go

@@ -40,11 +40,13 @@ type LinodeFirewallSpec struct {
 
 	// inboundRules is a list of FirewallRules that will be applied to the Firewall.
 	// +optional
+	// +listType=atomic
 	InboundRules []FirewallRuleSpec `json:"inboundRules,omitempty"`
 
 	// inboundRuleRefs is a list of references to FirewallRules as an alternative to
 	// using InboundRules but can be used in conjunction with it
 	// +optional
+	// +listType=atomic
 	InboundRuleRefs []*corev1.ObjectReference `json:"inboundRuleRefs,omitempty"`
 
 	// inboundPolicy determines if traffic by default should be ACCEPTed or DROPped. Defaults to ACCEPT if not defined.
@@ -55,11 +57,13 @@ type LinodeFirewallSpec struct {
 
 	// outboundRules is a list of FirewallRules that will be applied to the Firewall.
 	// +optional
+	// +listType=atomic
 	OutboundRules []FirewallRuleSpec `json:"outboundRules,omitempty"`
 
 	// outboundRuleRefs is a list of references to FirewallRules as an alternative to
 	// using OutboundRules but can be used in conjunction with it
 	// +optional
+	// +listType=atomic
 	OutboundRuleRefs []*corev1.ObjectReference `json:"outboundRuleRefs,omitempty"`
 
 	// outboundPolicy determines if traffic by default should be ACCEPTed or DROPped. Defaults to ACCEPT if not defined.

api/v1alpha2/linodemachine_types.go

@@ -64,11 +64,13 @@ type LinodeMachineSpec struct {
 	// authorizedKeys is a list of SSH public keys to add to the instance.
 	// +optional
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
+	// +listType=set
 	AuthorizedKeys []string `json:"authorizedKeys,omitempty"`
 
 	// authorizedUsers is a list of usernames to add to the instance.
 	// +optional
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
+	// +listType=set
 	AuthorizedUsers []string `json:"authorizedUsers,omitempty"`
 
 	// backupID is the ID of the backup to restore the instance from.
@@ -84,12 +86,14 @@ type LinodeMachineSpec struct {
 	// interfaces is a list of legacy network interfaces to use for the instance.
 	// +optional
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
+	// +listType=atomic
 	Interfaces []InstanceConfigInterfaceCreateOptions `json:"interfaces,omitempty"`
 
 	// linodeInterfaces is a list of Linode network interfaces to use for the instance. Requires Linode Interfaces beta opt-in to use.
 	// +optional
 	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
 	// +kubebuilder:object:generate=true
+	// +listType=atomic
 	LinodeInterfaces []LinodeInterfaceCreateOptions `json:"linodeInterfaces,omitempty"`
 
 	// backupsEnabled is a boolean indicating whether backups should be enabled for the instance.
@@ -104,6 +108,7 @@ type LinodeMachineSpec struct {
 
 	// tags is a list of tags to apply to the Linode instance.
 	// +optional
+	// +listType=set
 	Tags []string `json:"tags,omitempty"`
 
 	// firewallID is the id of the cloud firewall to apply to the Linode Instance
@@ -298,6 +303,7 @@ type InstanceConfigInterfaceCreateOptions struct {
 
 	// ipRanges is a list of IPv4 ranges to assign to the interface.
 	// +optional
+	// +listType=set
 	IPRanges []string `json:"ipRanges,omitempty"`
 }
 
@@ -350,6 +356,8 @@ type PublicInterfaceCreateOptions struct {
 type PublicInterfaceIPv4CreateOptions struct {
 	// addresses is the IPv4 addresses for the public interface.
 	// +optional
+	// +listType=map
+	// +listMapKey=address
 	Addresses []PublicInterfaceIPv4AddressCreateOptions `json:"addresses,omitempty"`
 }
 
@@ -368,6 +376,8 @@ type PublicInterfaceIPv4AddressCreateOptions struct {
 type PublicInterfaceIPv6CreateOptions struct {
 	// ranges is the IPv6 ranges for the public interface.
 	// +optional
+	// +listType=map
+	// +listMapKey=range
 	Ranges []PublicInterfaceIPv6RangeCreateOptions `json:"ranges,omitempty"`
 }
 
@@ -397,10 +407,14 @@ type VPCInterfaceCreateOptions struct {
 type VPCInterfaceIPv6CreateOptions struct {
 	// slaac is the IPv6 SLAAC configuration for the interface.
 	// +optional
+	// +listType=map
+	// +listMapKey=range
 	SLAAC []VPCInterfaceIPv6SLAACCreateOptions `json:"slaac,omitempty"`
 
 	// ranges is the IPv6 ranges for the interface.
 	// +optional
+	// +listType=map
+	// +listMapKey=range
 	Ranges []VPCInterfaceIPv6RangeCreateOptions `json:"ranges,omitempty"`
 
 	// is_public is a boolean indicating whether the interface is public.
@@ -426,10 +440,14 @@ type VPCInterfaceIPv6RangeCreateOptions struct {
 type VPCInterfaceIPv4CreateOptions struct {
 	// addresses is the IPv4 addresses for the interface.
 	// +optional
+	// +listType=map
+	// +listMapKey=address
 	Addresses []VPCInterfaceIPv4AddressCreateOptions `json:"addresses,omitempty"`
 
 	// ranges is the IPv4 ranges for the interface.
 	// +optional
+	// +listType=map
+	// +listMapKey=range
 	Ranges []VPCInterfaceIPv4RangeCreateOptions `json:"ranges,omitempty"`
 }
 
@@ -494,6 +512,8 @@ type LinodeMachineStatus struct {
 
 	// addresses contains the Linode instance associated addresses.
 	// +optional
+	// +listType=map
+	// +listMapKey=address
 	Addresses []clusterv1.MachineAddress `json:"addresses,omitempty"`
 
 	// cloudinitMetadataSupport determines whether to use cloud-init or not.
@@ -547,6 +567,7 @@ type LinodeMachineStatus struct {
 
 	// tags are the tags applied to the Linode Machine.
 	// +optional
+	// +listType=set
 	Tags []string `json:"tags,omitempty"`
 }
 

api/v1alpha2/linodemachinetemplate_types.go

@@ -40,6 +40,7 @@ type LinodeMachineTemplateStatus struct {
 
 	// tags that are currently applied to the LinodeMachineTemplate.
 	// +optional
+	// +listType=set
 	Tags []string `json:"tags,omitempty"`
 
 	// firewallID that is currently applied to the LinodeMachineTemplate.

api/v1alpha2/linodeobjectstoragekey_types.go

@@ -68,6 +68,7 @@ type LinodeObjectStorageKeySpec struct {
 	// bucketAccess is the list of object storage bucket labels which can be accessed using the key
 	// +kubebuilder:validation:MinItems=1
 	// +required
+	// +listType=atomic
 	BucketAccess []BucketAccessRef `json:"bucketAccess"`
 
 	// credentialsRef is a reference to a Secret that contains the credentials to use for generating access keys.

api/v1alpha2/linodevpc_types.go

@@ -47,16 +47,20 @@ type LinodeVPCSpec struct {
 	// Once ranges are allocated based on the IPv6Range field, they will be
 	// added to this field.
 	// +optional
+	// +listType=map
+	// +listMapKey=range
 	IPv6 []linodego.VPCIPv6Range `json:"ipv6,omitempty"`
 
 	// ipv6Range is a list of IPv6 ranges to allocate to the VPC.
 	// If not specified, the VPC will not have an IPv6 range allocated.
 	// Once ranges are allocated, they will be added to the IPv6 field.
 	// +optional
+	// +listType=atomic
 	IPv6Range []VPCCreateOptionsIPv6 `json:"ipv6Range,omitempty"`
 
 	// subnets is a list of subnets to create in the VPC.
 	// +optional
+	// +listType=atomic
 	Subnets []VPCSubnetCreateOptions `json:"subnets,omitempty"`
 
 	// retain allows you to keep the VPC after the LinodeVPC object is deleted.
@@ -103,12 +107,15 @@ type VPCSubnetCreateOptions struct {
 	// Once ranges are allocated based on the IPv6Range field, they will be
 	// added to this field.
 	// +optional
+	// +listType=map
+	// +listMapKey=range
 	IPv6 []linodego.VPCIPv6Range `json:"ipv6,omitempty"`
 
 	// ipv6Range is a list of IPv6 ranges to allocate to the subnet.
 	// If not specified, the subnet will not have an IPv6 range allocated.
 	// Once ranges are allocated, they will be added to the IPv6 field.
 	// +optional
+	// +listType=atomic
 	IPv6Range []VPCSubnetCreateOptionsIPv6 `json:"ipv6Range,omitempty"`
 
 	// subnetID is subnet id for the subnet

config/crd/bases/infrastructure.cluster.x-k8s.io_firewallrules.yaml

@@ -97,6 +97,7 @@ spec:
                   type: object
                   x-kubernetes-map-type: atomic
                 type: array
+                x-kubernetes-list-type: atomic
               addresses:
                 description: addresses is a list of addresses to apply the rule to.
                 properties:

config/crd/bases/infrastructure.cluster.x-k8s.io_linodeclusters.yaml

@@ -111,6 +111,9 @@ spec:
                       - port
                       type: object
                     type: array
+                    x-kubernetes-list-map-keys:
+                    - port
+                    x-kubernetes-list-type: map
                   apiserverLoadBalancerPort:
                     description: |-
                       apiserverLoadBalancerPort used by the api server. It must be valid ports range (1-65535).