Skip to content

[test] bump Flatcar tested version to Stable #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eljohnson92 merged 2 commits into from
Feb 12, 2025
Merged

[test] bump Flatcar tested version to Stable #569

eljohnson92 merged 2 commits into from
Feb 12, 2025

Conversation

@tormath1
Copy link
Contributor

@tormath1 tormath1 commented Nov 14, 2024 •
edited
Loading

What this PR does / why we need it: In this PR, we bump Flatcar channel to Stable. Akamai support (with GZIP compression support for user-data) is now available on Stable since the latest release.

Special notes for your reviewer: This is not tested yet

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@github-actions github-actions bot added the testing Pull requests that improve tests label Nov 14, 2024
@tormath1 tormath1 mentioned this pull request Nov 14, 2024
Closed
28 tasks
@tormath1 tormath1 force-pushed the tormath1/gzip branch 2 times, most recently from 1abc0ff to 39f461e Compare November 14, 2024 15:03
@tormath1 tormath1 force-pushed the tormath1/gzip branch 2 times, most recently from 516e498 to bbc3215 Compare February 5, 2025 14:44
@tormath1
main: rename cloud-init to user-data
07a7460 
This is more generic as CAPL does actually support two types of
user-data: Ignition and Cloud-init

Signed-off-by: Mathieu Tortuyaux <[email protected]>
@tormath1
e2e/flatcar: bump to Stable
bbbb1ac 
Stable Flatcar release does support GZIP compression

Signed-off-by: Mathieu Tortuyaux <[email protected]>
@tormath1 tormath1 changed the title [test] test gzip compression for Flatcar [test] bump Flatcar tested version to Stable Feb 5, 2025
@tormath1 tormath1 marked this pull request as ready for review February 5, 2025 14:48
@codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.21%. Comparing base (161f424) to head (bbbb1ac).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
cmd/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   63.21%   63.21%           
=======================================
  Files          70       70           
  Lines        6090     6090           
=======================================
  Hits         3850     3850           
  Misses       1976     1976           
  Partials      264      264

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tormath1 tormath1 mentioned this pull request Feb 5, 2025
Merged
@tormath1
Copy link
Contributor Author

tormath1 commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.21%. Comparing base (161f424) to head (bbbb1ac).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files

@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   63.21%   63.21%           
=======================================
  Files          70       70           
  Lines        6090     6090           
=======================================
  Hits         3850     3850           
  Misses       1976     1976           
  Partials      264      264

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

@eljohnson92 I'm not sure what to do with this? The code coverage is not decreasing so 🤷

@eljohnson92 eljohnson92 merged commit 439589a into linode:main Feb 12, 2025
9 of 11 checks passed
@tormath1 tormath1 deleted the tormath1/gzip branch February 12, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eljohnson92 eljohnson92 eljohnson92 approved these changes

Assignees

No one assigned

Labels

testing Pull requests that improve tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tormath1 @eljohnson92