[improvement] : allow CCM to work with different environments in CAPL #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulait
force-pushed
the
support-ccm-in-different-envs
branch
from
19aaa3d to
46323a8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 63.70% 63.70%
=======================================
Files 70 70
Lines 6053 6053
=======================================
Hits 3856 3856
Misses 1942 1942
Partials 255 255 ☔ View full report in Codecov by Sentry. |
komer3
reviewed
Jan 9, 2025
komer3
previously approved these changes
Jan 9, 2025
rahulait
force-pushed
the
support-ccm-in-different-envs
branch
from
85fdee6 to
5af7281
Compare
AshleyDumaine
pushed a commit
that referenced
this pull request
Jan 14, 2025
…#614) * allow CCM to work with different environments * address review comment * update other flavors as well for ccm env vars * add optional env vars for cilium-bgp mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows CCM to work with different environments. Support to allow CAPL to work with different environments was added in #546. This PR fixes CCM for child clusters. Along with other necessary vars required to provision a cluster, following vars also need to be set accordingly:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: