Skip to content

[improvement] : remove LINODE_CA and use LINODE_CA_BASE64 only#626

Merged
rahulait merged 2 commits intomainfrom
simplify-env-vars
Jan 15, 2025
Merged

[improvement] : remove LINODE_CA and use LINODE_CA_BASE64 only#626
rahulait merged 2 commits intomainfrom
simplify-env-vars

Conversation

@rahulait
Copy link
Contributor

@rahulait rahulait commented Jan 14, 2025

What this PR does / why we need it:
We set both LINODE_CA and LINODE_CA_BASE64 env vars. When LINODE_CA is set, we set SSL_CERT_DIR env var within the pod as we use x509.SystemCertPool() to set root CAs.
LINODE_CA_BASE64 is used to set CA content in secret used by child clusters as clusterctl doesn't allow us to read from file and set the content.
Instead of having two vars, we can remove one and just rely on LINODE_CA_BASE64.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.62%. Comparing base (dba0683) to head (9d5cb0b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   63.62%   63.62%           
=======================================
  Files          70       70           
  Lines        6056     6056           
=======================================
  Hits         3853     3853           
  Misses       1946     1946           
  Partials      257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulait rahulait merged commit 39b0522 into main Jan 15, 2025
14 checks passed
@rahulait rahulait deleted the simplify-env-vars branch March 17, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants