[improvement] : remove LINODE_CA and use LINODE_CA_BASE64 only#626
Merged
[improvement] : remove LINODE_CA and use LINODE_CA_BASE64 only#626
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
=======================================
Coverage 63.62% 63.62%
=======================================
Files 70 70
Lines 6056 6056
=======================================
Hits 3853 3853
Misses 1946 1946
Partials 257 257 ☔ View full report in Codecov by Sentry. |
3542d33 to
ee9fbcb
Compare
ee9fbcb to
879770f
Compare
AshleyDumaine
approved these changes
Jan 15, 2025
komer3
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We set both
LINODE_CAandLINODE_CA_BASE64env vars. WhenLINODE_CAis set, we setSSL_CERT_DIRenv var within the pod as we use x509.SystemCertPool() to set root CAs.LINODE_CA_BASE64is used to set CA content in secret used by child clusters asclusterctldoesn't allow us to read from file and set the content.Instead of having two vars, we can remove one and just rely on
LINODE_CA_BASE64.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: