Skip to content

[improvement] toggle cis hardening for rke2 clusters#696

Merged
AshleyDumaine merged 1 commit intomainfrom
rke2-cis-toggle
Mar 11, 2025
Merged

[improvement] toggle cis hardening for rke2 clusters#696
AshleyDumaine merged 1 commit intomainfrom
rke2-cis-toggle

Conversation

@AshleyDumaine
Copy link
Collaborator

What this PR does / why we need it: RKE2 clusters have CIS hardening hard-coded to on. This makes that configurable and defaults it to off, mainly because templating the CIS_PROFILE is finicky. Trying to set the value to an empty string gets interpreted as unset which causes the empty value to be overwritten to enabled on the clusterctl generate.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.01%. Comparing base (c6337fb) to head (e8284be).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #696   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files          70       70           
  Lines        6367     6367           
=======================================
  Hits         4076     4076           
  Misses       2019     2019           
  Partials      272      272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AshleyDumaine AshleyDumaine merged commit 4c013d7 into main Mar 11, 2025
16 checks passed
@AshleyDumaine AshleyDumaine deleted the rke2-cis-toggle branch March 17, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants