[improvement] toggle cis hardening for rke2 clusters#696
Merged
AshleyDumaine merged 1 commit intomainfrom Mar 11, 2025
Merged
Conversation
rahulait
approved these changes
Mar 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
=======================================
Coverage 64.01% 64.01%
=======================================
Files 70 70
Lines 6367 6367
=======================================
Hits 4076 4076
Misses 2019 2019
Partials 272 272 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eljohnson92
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: RKE2 clusters have CIS hardening hard-coded to on. This makes that configurable and defaults it to off, mainly because templating the CIS_PROFILE is finicky. Trying to set the value to an empty string gets interpreted as unset which causes the empty value to be overwritten to enabled on the
clusterctl generate.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: