Skip to content

[feat] : add nodeipam-ccm flavor#730

Merged
rahulait merged 1 commit intomainfrom
nodeipam-ccm-flavor
Apr 8, 2025
Merged

[feat] : add nodeipam-ccm flavor#730
rahulait merged 1 commit intomainfrom
nodeipam-ccm-flavor

Conversation

@rahulait
Copy link
Contributor

@rahulait rahulait commented Apr 8, 2025

What this PR does / why we need it:
This PR adds nodeipam-ccm flavor for kubeadm based clusters. It disables nodeipam controller within kube-controller-manager and enables it within CCM which does the ipv4 node ipam for the cluster.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@rahulait rahulait force-pushed the nodeipam-ccm-flavor branch from 41e0e38 to 0f375ca Compare April 8, 2025 20:45
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.22%. Comparing base (c68a6c3) to head (0f375ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #730   +/-   ##
=======================================
  Coverage   65.22%   65.22%           
=======================================
  Files          69       69           
  Lines        6597     6597           
=======================================
  Hits         4303     4303           
  Misses       2041     2041           
  Partials      253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@AshleyDumaine AshleyDumaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulait rahulait merged commit ca9b199 into main Apr 8, 2025
14 checks passed
@AshleyDumaine AshleyDumaine deleted the nodeipam-ccm-flavor branch June 2, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants