[feat] support path style bucket references in the cluster object store#798
Merged
eljohnson92 merged 1 commit intomainfrom Jul 14, 2025
Merged
[feat] support path style bucket references in the cluster object store#798eljohnson92 merged 1 commit intomainfrom
eljohnson92 merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for path-style addressing for object store buckets by reading a new environment variable and applying it to the S3 client configuration.
- Introduces
LINODE_OBJECT_STORAGE_USE_PATH_STYLEenv var to toggle path-style addressing - Sets
opts.UsePathStyleon the S3 client based on that variable
Comments suppressed due to low confidence (2)
cloud/scope/common.go:132
- [nitpick] The local variable
ObjUsePathStylestarts with an uppercase letter, which is unconventional for Go locals. Consider renaming it toobjUsePathStylefor idiomatic consistency.
if ObjUsePathStyle := os.Getenv("LINODE_OBJECT_STORAGE_USE_PATH_STYLE"); strings.ToLower(ObjUsePathStyle) == "true" {
cloud/scope/common.go:131
- Please document the new
LINODE_OBJECT_STORAGE_USE_PATH_STYLEenvironment variable in the README or relevant configuration docs so users know how to enable path-style addressing.
usePathStyle := false
ff348de to
169a8ee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #798 +/- ##
=======================================
Coverage 62.82% 62.83%
=======================================
Files 71 71
Lines 7177 7178 +1
=======================================
+ Hits 4509 4510 +1
Misses 2401 2401
Partials 267 267 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rahulait
approved these changes
Jul 10, 2025
AshleyDumaine
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
this PR supports path style obj buckets for cluster object stores
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: