Skip to content

Conversation

@eljohnson92
Copy link
Collaborator

What this PR does / why we need it:
this PR supports path style obj buckets for cluster object stores
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for path-style addressing for object store buckets by reading a new environment variable and applying it to the S3 client configuration.

  • Introduces LINODE_OBJECT_STORAGE_USE_PATH_STYLE env var to toggle path-style addressing
  • Sets opts.UsePathStyle on the S3 client based on that variable
Comments suppressed due to low confidence (2)

cloud/scope/common.go:132

  • [nitpick] The local variable ObjUsePathStyle starts with an uppercase letter, which is unconventional for Go locals. Consider renaming it to objUsePathStyle for idiomatic consistency.
		if ObjUsePathStyle := os.Getenv("LINODE_OBJECT_STORAGE_USE_PATH_STYLE"); strings.ToLower(ObjUsePathStyle) == "true" {

cloud/scope/common.go:131

  • Please document the new LINODE_OBJECT_STORAGE_USE_PATH_STYLE environment variable in the README or relevant configuration docs so users know how to enable path-style addressing.
		usePathStyle := false

@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.83%. Comparing base (cb589b3) to head (169a8ee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #798   +/-   ##
=======================================
  Coverage   62.82%   62.83%           
=======================================
  Files          71       71           
  Lines        7177     7178    +1     
=======================================
+ Hits         4509     4510    +1     
  Misses       2401     2401           
  Partials      267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eljohnson92 eljohnson92 merged commit 547dd52 into main Jul 14, 2025
16 checks passed
@AshleyDumaine AshleyDumaine deleted the obj-path-style branch September 9, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants