Skip to content

[improvement] Add NetworkHelper field to LinodeMachineSpec and update instance configuration logic#806

Merged
komer3 merged 6 commits intomainfrom
enable-network-helper
Jul 22, 2025
Merged

[improvement] Add NetworkHelper field to LinodeMachineSpec and update instance configuration logic#806
komer3 merged 6 commits intomainfrom
enable-network-helper

Conversation

@komer3
Copy link
Contributor

@komer3 komer3 commented Jul 21, 2025

  • Introduced a new optional boolean field NetworkHelper in LinodeMachineSpec to indicate if the network helper should be used, defaulting to true.
  • Updated the instance configuration logic in linodemachine_controller.go to enable the network helper based on the new field.

Note: Disabled for flatcar based flavor (set to false)

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

…iguration logic

- Introduced a new optional boolean field `NetworkHelper` in `LinodeMachineSpec` to indicate if the network helper should be used, defaulting to true.
- Updated the instance configuration logic in `linodemachine_controller.go` to conditionally enable the network helper based on the new field.
- Updated the comment for the `NetworkHelper` field in `LinodeMachineSpec` to provide clearer guidance on its purpose and usage.
- Added a link to the relevant documentation for automatic networking configuration.
@komer3 komer3 marked this pull request as ready for review July 21, 2025 21:16
@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.16%. Comparing base (eb218ad) to head (a10de84).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/linodemachine_controller.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
- Coverage   63.16%   63.16%   -0.01%     
==========================================
  Files          71       71              
  Lines        7292     7305      +13     
==========================================
+ Hits         4606     4614       +8     
- Misses       2415     2419       +4     
- Partials      271      272       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@komer3 komer3 merged commit ae140f5 into main Jul 22, 2025
18 checks passed
@komer3 komer3 deleted the enable-network-helper branch July 22, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants