Skip to content

Conversation

@rahulait
Copy link
Contributor

What this PR does / why we need it:
This PR uses label for filtering if vpc id is not yet set. Once vpc id gets set, its used going forward for filtering.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.16%. Comparing base (54184a9) to head (74b86fc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
+ Coverage   63.14%   63.16%   +0.02%     
==========================================
  Files          71       71              
  Lines        7332     7336       +4     
==========================================
+ Hits         4630     4634       +4     
  Misses       2428     2428              
  Partials      274      274              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eljohnson92 eljohnson92 merged commit 058c8f0 into main Jul 24, 2025
15 of 16 checks passed
@AshleyDumaine AshleyDumaine deleted the fix-vpc-filtering branch September 9, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants