Skip to content

Conversation

@rosskirkpat
Copy link
Collaborator

What this PR does / why we need it:

  • increase default NOFILE limits for systemd services.
    • containerd set to infinite
    • all services increased to 65535

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.18%. Comparing base (6608cb3) to head (46fae72).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #812   +/-   ##
=======================================
  Coverage   63.18%   63.18%           
=======================================
  Files          71       71           
  Lines        7356     7356           
=======================================
  Hits         4648     4648           
  Misses       2435     2435           
  Partials      273      273           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rosskirkpat rosskirkpat force-pushed the rk/set-nofile-limits branch from 422f3ea to e65d48d Compare July 24, 2025 19:08
@rosskirkpat rosskirkpat requested a review from Copilot July 24, 2025 19:08

This comment was marked as outdated.

This comment was marked as outdated.

komer3
komer3 previously approved these changes Jul 24, 2025

This comment was marked as outdated.

@rosskirkpat rosskirkpat force-pushed the rk/set-nofile-limits branch from 234b7cf to ed30c64 Compare July 24, 2025 19:34
@rosskirkpat rosskirkpat requested a review from Copilot July 24, 2025 19:34

This comment was marked as outdated.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR configures NOFILE (file descriptor) limits for systemd services to support high-performance containerized workloads. The changes set containerd's NOFILE limit to infinity and establish default NOFILE limits of 65535 (soft) and 1048576 (hard) for all systemd services.

  • Sets infinite NOFILE limit for containerd service to handle high file descriptor usage
  • Configures system-wide default NOFILE limits via systemd configuration
  • Improves error handling and shell script best practices throughout the setup script

@eljohnson92 eljohnson92 force-pushed the rk/set-nofile-limits branch from 3887b95 to 46fae72 Compare August 4, 2025 17:38
@eljohnson92 eljohnson92 merged commit 00a50e0 into main Aug 4, 2025
16 checks passed
@eljohnson92 eljohnson92 changed the title set NOFILE limits for containerd and systemd [improvement] set NOFILE limits for containerd and systemd Aug 5, 2025
@AshleyDumaine AshleyDumaine deleted the rk/set-nofile-limits branch September 9, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants