Skip to content

[improvement] : allow configuring timeout value for linodeclient#822

Merged
eljohnson92 merged 1 commit intomainfrom
allow-custom-linode-client-timeout
Aug 4, 2025
Merged

[improvement] : allow configuring timeout value for linodeclient#822
eljohnson92 merged 1 commit intomainfrom
allow-custom-linode-client-timeout

Conversation

@rahulait
Copy link
Contributor

@rahulait rahulait commented Aug 2, 2025

What this PR does / why we need it:
This PR allows us to have custom timeout value for linode client. If the relevant env var is set, capl-controller-manager deployment will get the flag set via tilt.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@codecov
Copy link

codecov bot commented Aug 2, 2025

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.05%. Comparing base (058c8f0) to head (639b6e4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/main.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
- Coverage   63.16%   63.05%   -0.12%     
==========================================
  Files          71       71              
  Lines        7336     7349      +13     
==========================================
  Hits         4634     4634              
- Misses       2428     2441      +13     
  Partials      274      274              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eljohnson92 eljohnson92 merged commit 8e76abd into main Aug 4, 2025
14 of 17 checks passed
@AshleyDumaine AshleyDumaine deleted the allow-custom-linode-client-timeout branch August 4, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants