Skip to content

[feat] remove defaultLinodeClient used by webhooks in favor of always using an authenticated client#836

Merged
eljohnson92 merged 1 commit intomainfrom
update-webhook-client
Aug 19, 2025
Merged

[feat] remove defaultLinodeClient used by webhooks in favor of always using an authenticated client#836
eljohnson92 merged 1 commit intomainfrom
update-webhook-client

Conversation

@eljohnson92
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.65%. Comparing base (d83700f) to head (e6e30ce).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/webhook/v1alpha2/webhook_helpers.go 58.33% 4 Missing and 1 partial ⚠️
...hook/v1alpha2/linodeobjectstoragebucket_webhook.go 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
+ Coverage   63.46%   63.65%   +0.18%     
==========================================
  Files          71       71              
  Lines        7833     7827       -6     
==========================================
+ Hits         4971     4982      +11     
+ Misses       2570     2555      -15     
+ Partials      292      290       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eljohnson92 eljohnson92 merged commit 7177085 into main Aug 19, 2025
16 checks passed
@AshleyDumaine AshleyDumaine deleted the update-webhook-client branch August 19, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants