[improvement] enable the optionalorrequired linter for the various APIs#841
Merged
eljohnson92 merged 1 commit intomainfrom Aug 27, 2025
Merged
[improvement] enable the optionalorrequired linter for the various APIs#841eljohnson92 merged 1 commit intomainfrom
optionalorrequired linter for the various APIs#841eljohnson92 merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #841 +/- ##
=======================================
Coverage 63.65% 63.65%
=======================================
Files 71 71
Lines 7827 7827
=======================================
Hits 4982 4982
Misses 2555 2555
Partials 290 290 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
komer3
reviewed
Aug 21, 2025
komer3
reviewed
Aug 22, 2025
eljohnson92
force-pushed
the
kal_optional_or_required
branch
from
ba19244 to
3be4861
Compare
| type FirewallRuleList struct { | ||
| metav1.TypeMeta `json:",inline"` | ||
| // metadata is the standard object's metadata. | ||
| // +optional |
Collaborator
There was a problem hiding this comment.
Missing optional below for Items? But also, wouldn't Items for all the *List structs be required since we don't have omitempty?
api/v1alpha2/addressset_types.go
Outdated
| // +optional | ||
| metav1.ObjectMeta `json:"metadata,omitempty"` | ||
| // spec is the desired state of the AddressSet | ||
| // +required |
Collaborator
There was a problem hiding this comment.
We probably only want required if omitempty isn't present.
eljohnson92
force-pushed
the
kal_optional_or_required
branch
from
0cf8ef4 to
2e9705c
Compare
komer3
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: