Skip to content

[test][fix] E2E test improvements, add missing client for the LOBJ webhook#842

Merged
AshleyDumaine merged 6 commits intomainfrom
e2e-improvements
Aug 27, 2025
Merged

[test][fix] E2E test improvements, add missing client for the LOBJ webhook#842
AshleyDumaine merged 6 commits intomainfrom
e2e-improvements

Conversation

@AshleyDumaine
Copy link
Collaborator

What this PR does / why we need it: Sometimes resources get orphaned by the chainsaw tests and because the names are tied to the git ref, retriggering a run because of a transient issue like a 503 on a dependency will cause the test to fail until the orphaned resource is cleaned up. This PR uses the kyverno chainsaw random function to fix that so tests can be retried regardless of the orphaned resource.
This also gets rid of the min-obj bucket tests in favor of force deletion since we want test buckets to clean up.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.65%. Comparing base (88ea5dd) to head (f0f6128).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...hook/v1alpha2/linodeobjectstoragebucket_webhook.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #842   +/-   ##
=======================================
  Coverage   63.65%   63.65%           
=======================================
  Files          71       71           
  Lines        7827     7827           
=======================================
  Hits         4982     4982           
  Misses       2555     2555           
  Partials      290      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

eljohnson92
eljohnson92 previously approved these changes Aug 26, 2025
@AshleyDumaine AshleyDumaine merged commit 9f4d0a7 into main Aug 27, 2025
19 of 20 checks passed
@AshleyDumaine AshleyDumaine deleted the e2e-improvements branch August 27, 2025 15:58
glennpratt pushed a commit to glennpratt/cluster-api-provider-linode that referenced this pull request Oct 12, 2025
…bhook (linode#842)

* use the random function instead of the GIT_REF since once in a while resources linger and cause tests to fail

* remove min-obj tests in favor of force-delete tests

* add missing client

* comment out no-op tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix testing Pull requests that improve tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants