Skip to content

[fix] check machine readiness before adding to DNS#979

Merged
AshleyDumaine merged 2 commits intomainfrom
check-machine-readiness
Dec 23, 2025
Merged

[fix] check machine readiness before adding to DNS#979
AshleyDumaine merged 2 commits intomainfrom
check-machine-readiness

Conversation

@tchinmai7
Copy link
Contributor

What this PR does / why we need it:
Checks for CAPI machine readiness before adding a LinodeMachine's IP to DNS.
This prevents linodemachines that were just provisioned, but have no pods running from being added to the DNS response.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.69%. Comparing base (69cab7f) to head (4e7777f).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
+ Coverage   66.64%   66.69%   +0.05%     
==========================================
  Files          71       71              
  Lines        6352     6363      +11     
==========================================
+ Hits         4233     4244      +11     
  Misses       1820     1820              
  Partials      299      299              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rosskirkpat
rosskirkpat previously approved these changes Dec 18, 2025
Co-authored-by: Ashley Dumaine <5779804+AshleyDumaine@users.noreply.github.com>
@AshleyDumaine AshleyDumaine merged commit 6acdb65 into main Dec 23, 2025
16 checks passed
@AshleyDumaine AshleyDumaine deleted the check-machine-readiness branch December 23, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants