[fix] check machine readiness before adding to DNS#979
Merged
AshleyDumaine merged 2 commits intomainfrom Dec 23, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
==========================================
+ Coverage 66.64% 66.69% +0.05%
==========================================
Files 71 71
Lines 6352 6363 +11
==========================================
+ Hits 4233 4244 +11
Misses 1820 1820
Partials 299 299 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rosskirkpat
previously approved these changes
Dec 18, 2025
Co-authored-by: Ashley Dumaine <5779804+AshleyDumaine@users.noreply.github.com>
AshleyDumaine
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Checks for CAPI machine readiness before adding a LinodeMachine's IP to DNS.
This prevents linodemachines that were just provisioned, but have no pods running from being added to the DNS response.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: