Configure API token using LinodeClient{}.SetToken(...) rather than transport; allow configuring LINODE_CA #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request updates the linodego.Client creation logic to set the user-configured API token using the
LinodeClient{}.SetToken(...)function rather than using a custom oauth2 transport. This allows theLINODE_CAenvironment variable to be specified without any additional logic to set the trusted root CA, which is necessary because linodego can only modify an HTTP client's trusted CAs if the user-provided client's RoundTripper is a *http.Transport.✔️ How to Test
The following test steps assume you have pulled down this PR locally, have Ansible installed, have an SSH public key exported under
~/.ssh/id_rsa.pub, and have a valid Linode API token exported under theLINODE_TOKENenvironment variable.Integration Testing
Manual Testing
TODO