Skip to content

Conversation

@guilhem
Copy link
Contributor

@guilhem guilhem commented Jun 4, 2025

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@guilhem guilhem requested review from a team as code owners June 4, 2025 10:18
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.69%. Comparing base (56c19c7) to head (19d3f17).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   70.69%   70.69%           
=======================================
  Files          24       24           
  Lines        2761     2761           
=======================================
  Hits         1952     1952           
  Misses        681      681           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guilhem guilhem requested a review from Copilot June 4, 2025 10:30

This comment was marked as outdated.

@guilhem guilhem force-pushed the annotationsandlabels branch from 4966ccf to abb4acd Compare June 4, 2025 10:36
@guilhem guilhem force-pushed the annotationsandlabels branch from abb4acd to 19d3f17 Compare June 4, 2025 10:40
@guilhem guilhem requested a review from Copilot June 4, 2025 10:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for injecting custom Kubernetes pod labels and annotations into the CSI driver Helm chart.

  • Introduces podLabels and podAnnotations fields in values.yaml
  • Renders those fields in both the DaemonSet and Controller manifests

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
helm-chart/csi-driver/values.yaml Added top-level podLabels and podAnnotations keys
helm-chart/csi-driver/templates/daemonset.yaml Injects .Values.podLabels and .Values.podAnnotations into DaemonSet metadata
helm-chart/csi-driver/templates/csi-linode-controller.yaml Injects .Values.podLabels and .Values.podAnnotations into Controller metadata
Comments suppressed due to low confidence (4)

helm-chart/csi-driver/values.yaml:108

  • podAnnotations and podLabels are not indented under the controller: block. They should have the same 4-space indentation level as tolerations to ensure they're read in the correct scope.
podAnnotations: {}

helm-chart/csi-driver/values.yaml:111

  • podLabels is misaligned at the root level. Indent it two spaces so it belongs inside the controller: section alongside nodeSelector, affinity, and tolerations.
podLabels: {}

helm-chart/csi-driver/templates/daemonset.yaml:20

  • This with .Values.podAnnotations block is only indented 6 spaces, which aligns it with spec: instead of under metadata:. Increase its indent to match the labels: block (8 spaces) so annotations: is placed next to labels: in the pod metadata.
{{- with .Values.podAnnotations }}

helm-chart/csi-driver/templates/csi-linode-controller.yaml:22

  • This annotations block is misaligned at the same level as spec:. It should be indented to the same level as the labels: keys (8 spaces) to correctly nest under metadata.
{{- with .Values.podAnnotations }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant