-
Notifications
You must be signed in to change notification settings - Fork 63
feat(helm): add podAnnotations and podLabels #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
=======================================
Coverage 70.69% 70.69%
=======================================
Files 24 24
Lines 2761 2761
=======================================
Hits 1952 1952
Misses 681 681
Partials 128 128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4966ccf to
abb4acd
Compare
abb4acd to
19d3f17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for injecting custom Kubernetes pod labels and annotations into the CSI driver Helm chart.
- Introduces
podLabelsandpodAnnotationsfields invalues.yaml - Renders those fields in both the DaemonSet and Controller manifests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| helm-chart/csi-driver/values.yaml | Added top-level podLabels and podAnnotations keys |
| helm-chart/csi-driver/templates/daemonset.yaml | Injects .Values.podLabels and .Values.podAnnotations into DaemonSet metadata |
| helm-chart/csi-driver/templates/csi-linode-controller.yaml | Injects .Values.podLabels and .Values.podAnnotations into Controller metadata |
Comments suppressed due to low confidence (4)
helm-chart/csi-driver/values.yaml:108
podAnnotationsandpodLabelsare not indented under thecontroller:block. They should have the same 4-space indentation level astolerationsto ensure they're read in the correct scope.
podAnnotations: {}
helm-chart/csi-driver/values.yaml:111
podLabelsis misaligned at the root level. Indent it two spaces so it belongs inside thecontroller:section alongsidenodeSelector,affinity, andtolerations.
podLabels: {}
helm-chart/csi-driver/templates/daemonset.yaml:20
- This
with .Values.podAnnotationsblock is only indented 6 spaces, which aligns it withspec:instead of undermetadata:. Increase its indent to match thelabels:block (8 spaces) soannotations:is placed next tolabels:in the pod metadata.
{{- with .Values.podAnnotations }}
helm-chart/csi-driver/templates/csi-linode-controller.yaml:22
- This annotations block is misaligned at the same level as
spec:. It should be indented to the same level as thelabels:keys (8 spaces) to correctly nest under metadata.
{{- with .Values.podAnnotations }}
General:
Pull Request Guidelines: