Skip to content

Conversation

@guilhem
Copy link
Contributor

@guilhem guilhem commented Jun 4, 2025

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@guilhem guilhem requested review from a team as code owners June 4, 2025 12:05
@guilhem guilhem requested a review from Copilot June 4, 2025 12:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom pod annotations and labels in the CSI driver Helm chart to enable users to easily configure these metadata fields.

  • Introduces new values keys "podAnnotations" and "podLabels" in values.yaml.
  • Integrates these keys into both the daemonset and the controller templates.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
helm-chart/csi-driver/values.yaml Adds entries for podAnnotations and podLabels
helm-chart/csi-driver/templates/daemonset.yaml Inserts podAnnotations and podLabels into the daemonset metadata block
helm-chart/csi-driver/templates/csi-linode-controller.yaml Inserts podAnnotations and podLabels into the controller metadata block
Comments suppressed due to low confidence (2)

helm-chart/csi-driver/templates/daemonset.yaml:20

  • Review the YAML indentation for the podAnnotations block to ensure that it aligns correctly within the metadata section; inconsistent indentations can lead to YAML parsing issues.
{{- with .Values.podAnnotations }}

helm-chart/csi-driver/templates/csi-linode-controller.yaml:22

  • Verify that the indentation and structure of the podAnnotations block is consistent with the labels block to maintain readability and prevent formatting issues.
{{- with .Values.podAnnotations }}

@komer3 komer3 added the new-feature for new features in the changelog. label Jun 5, 2025
@komer3 komer3 merged commit 723b954 into main Jun 5, 2025
24 of 28 checks passed
@AshleyDumaine AshleyDumaine deleted the annotationsandlabels branch June 6, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants