Skip to content

Conversation

@amold1
Copy link
Contributor

@amold1 amold1 commented Dec 19, 2025

What this PR does / why we need it:
Currently, the way ci pipeline is setup, exposes a risk for Fork Network Manipulation ultimately achieving remote code execution. This happens as a result of the way we are setting up environments based on forked repos.
As a result, the attacker gains control over the workflow, giving them access to the GitHub Actions Cache. This allows the attacker to, via a Cache Poisoning attack, compromise over workflows to gain write-all access to the repository, and control over the certain repo/org secrets.

We are now explicitly requiring that the prod environment be used on PR only when the repo name matches this repo, and not forked repos in GHA runs

@amold1 amold1 requested review from a team as code owners December 19, 2025 16:04
@amold1 amold1 changed the title update gha file to mitigate Fork Network Manipulation vuln [fix] [ci] update gha file to mitigate Fork Network Manipulation vuln Dec 19, 2025
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.53%. Comparing base (6738a18) to head (d699d5f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   70.53%   70.53%           
=======================================
  Files          24       24           
  Lines        2118     2118           
=======================================
  Hits         1494     1494           
  Misses        496      496           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amold1 amold1 merged commit 355411d into main Dec 19, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants