placements_tests #703
Closed
placements_tests #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshanthe
requested review from
ezilber-akamai,
ykim-akamai and
zliang-akamai
and removed request for
a team
ezilber-akamai
approved these changes
Dec 18, 2024
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
LGTM! Tests passing locally.
ykim-akamai
reviewed
Dec 20, 2024
| ] | ||
| ) | ||
| assert placement_group_id in res | ||
| assert process.returncode == 0 |
Contributor
There was a problem hiding this comment.
Fyi, returncode assertion is done in exec_command function. Can we have different set of assertions that linode actually got assigned?
ykim-akamai
reviewed
Dec 20, 2024
| ] | ||
| ) | ||
| assert placement_group_id not in res | ||
| assert process.returncode == 0 |
Contributor
There was a problem hiding this comment.
Same here, can we verify that linode is un-assigned?
Contributor
Author
|
Creating new request with adding new changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Altered some tests for Placement group and added back to the integration suite
✔️ How to Test
make MODULE=placements testint
**
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.