remove tests

Author: tchinmai7

cloud/linode/loadbalancers_test.go

@@ -311,10 +311,6 @@ func TestCCMLoadBalancers(t *testing.T) {
 			name: "Update Load Balancer - No Nodes",
 			f:    testUpdateLoadBalancerNoNodes,
 		},
-		{
-			name: "Update Load Balancer - Node excluded by annotation",
-			f:    testUpdateLoadBalancerNodeExcludedByAnnotation,
-		},
 		{
 			name: "Create Load Balancer - Very long Service name",
 			f:    testVeryLongServiceName,
@@ -4650,248 +4646,6 @@ func testCleanupDoesntCall(t *testing.T, client *linodego.Client, fakeAPI *fakeA
 	})
 }
 
-func testUpdateLoadBalancerNodeExcludedByAnnotation(t *testing.T, client *linodego.Client, _ *fakeAPI) {
-	t.Helper()
-	svc := &v1.Service{
-		ObjectMeta: metav1.ObjectMeta{
-			Name:        randString(),
-			UID:         "foobar123",
-			Annotations: map[string]string{},
-		},
-		Spec: v1.ServiceSpec{
-			Ports: []v1.ServicePort{
-				{
-					Name:     randString(),
-					Protocol: "http",
-					Port:     int32(80),
-					NodePort: int32(8080),
-				},
-			},
-		},
-	}
-
-	lb, assertion := newLoadbalancers(client, "us-west").(*loadbalancers)
-	if !assertion {
-		t.Error("type assertion failed")
-	}
-	defer func() {
-		_ = lb.EnsureLoadBalancerDeleted(t.Context(), "linodelb", svc)
-	}()
-
-	fakeClientset := fake.NewSimpleClientset()
-	lb.kubeClient = fakeClientset
-
-	nodeBalancer, err := client.CreateNodeBalancer(t.Context(), linodego.NodeBalancerCreateOptions{
-		Region: lb.zone,
-	})
-	if err != nil {
-		t.Fatalf("failed to create NodeBalancer: %s", err)
-	}
-	svc.Status.LoadBalancer = *makeLoadBalancerStatus(svc, nodeBalancer)
-	stubService(fakeClientset, svc)
-	svc.SetAnnotations(map[string]string{
-		annotations.AnnLinodeNodeBalancerID: strconv.Itoa(nodeBalancer.ID),
-	})
-
-	// setup done, test ensure/update
-	nodes := []*v1.Node{
-		{
-			ObjectMeta: metav1.ObjectMeta{
-				Name: "node-1",
-			},
-			Status: v1.NodeStatus{
-				Addresses: []v1.NodeAddress{
-					{
-						Type:    v1.NodeInternalIP,
-						Address: "127.0.0.1",
-					},
-				},
-			},
-		},
-		{
-			ObjectMeta: metav1.ObjectMeta{
-				Name: "node-2",
-				Labels: map[string]string{
-					v1.LabelNodeExcludeBalancers: "true",
-				},
-			},
-			Status: v1.NodeStatus{
-				Addresses: []v1.NodeAddress{
-					{
-						Type:    v1.NodeInternalIP,
-						Address: "127.0.0.2",
-					},
-				},
-			},
-		},
-		{
-			ObjectMeta: metav1.ObjectMeta{
-				Name: "node-3",
-			},
-			Status: v1.NodeStatus{
-				Addresses: []v1.NodeAddress{
-					{
-						Type:    v1.NodeInternalIP,
-						Address: "127.0.0.3",
-					},
-				},
-			},
-		},
-	}
-
-	// Test initial creation - should only create nodes that aren't excluded
-	lbStatus, err := lb.EnsureLoadBalancer(t.Context(), "linodelb", svc, nodes)
-	if err != nil {
-		t.Fatalf("expected no error got %v", err)
-	}
-	svc.Status.LoadBalancer = *lbStatus
-	stubServiceUpdate(fakeClientset, svc)
-	nodeBalancerNodes := getLatestNbNodesForService(t, client, svc, lb)
-	// Should have only 2 nodes (node-1 and node-3), since node-2 is excluded
-	if len(nodeBalancerNodes) != 2 {
-		t.Errorf("expected 2 nodes, got %d", len(nodeBalancerNodes))
-	}
-
-	// Verify excluded node is not present
-	for _, nbNode := range nodeBalancerNodes {
-		if strings.Contains(nbNode.Label, "node-2") {
-			t.Errorf("excluded node 'node-2' should not be present in nodeBalancer nodes")
-		}
-	}
-
-	// Test Update operation
-	updatedNodes := []*v1.Node{
-		{
-			ObjectMeta: metav1.ObjectMeta{
-				Name: "node-1",
-				Labels: map[string]string{
-					v1.LabelNodeExcludeBalancers: "true",
-				},
-			},
-			Status: v1.NodeStatus{
-				Addresses: []v1.NodeAddress{
-					{
-						Type:    v1.NodeInternalIP,
-						Address: "127.0.0.1",
-					},
-				},
-			},
-		},
-		{
-			ObjectMeta: metav1.ObjectMeta{
-				Name: "node-2",
-				Labels: map[string]string{
-					v1.LabelNodeExcludeBalancers: "true",
-				},
-			},
-			Status: v1.NodeStatus{
-				Addresses: []v1.NodeAddress{
-					{
-						Type:    v1.NodeInternalIP,
-						Address: "127.0.0.2",
-					},
-				},
-			},
-		},
-		{
-			ObjectMeta: metav1.ObjectMeta{
-				Name: "node-3",
-			},
-			Status: v1.NodeStatus{
-				Addresses: []v1.NodeAddress{
-					{
-						Type:    v1.NodeInternalIP,
-						Address: "127.0.0.3",
-					},
-				},
-			},
-		},
-	}
-
-	// Update the load balancer with updated nodes
-	if err = lb.UpdateLoadBalancer(t.Context(), "linodelb", svc, updatedNodes); err != nil {
-		t.Fatalf("unexpected error updating LoadBalancer: %v", err)
-	}
-
-	// Verify nodes were updated correctly
-	nodeBalancerNodesAfterUpdate := getLatestNbNodesForService(t, client, svc, lb)
-
-	// Should have only 1 node (node-3), since both node-1 and node-2 are excluded
-	if len(nodeBalancerNodesAfterUpdate) != 1 {
-		t.Errorf("expected 1 node after update, got %d", len(nodeBalancerNodesAfterUpdate))
-	}
-
-	// Verify excluded nodes are not present
-	for _, nbNode := range nodeBalancerNodesAfterUpdate {
-		if strings.Contains(nbNode.Label, "node-1") || strings.Contains(nbNode.Label, "node-2") {
-			t.Errorf("excluded nodes should not be present in nodeBalancer nodes after update")
-		}
-	}
-
-	// Test edge case: all nodes excluded
-	allExcludedNodes := []*v1.Node{
-		{
-			ObjectMeta: metav1.ObjectMeta{
-				Name: "node-1",
-				Labels: map[string]string{
-					v1.LabelNodeExcludeBalancers: "true",
-				},
-			},
-			Status: v1.NodeStatus{
-				Addresses: []v1.NodeAddress{
-					{
-						Type:    v1.NodeInternalIP,
-						Address: "127.0.0.1",
-					},
-				},
-			},
-		},
-		{
-			ObjectMeta: metav1.ObjectMeta{
-				Name: "node-2",
-				Labels: map[string]string{
-					v1.LabelNodeExcludeBalancers: "true",
-				},
-			},
-			Status: v1.NodeStatus{
-				Addresses: []v1.NodeAddress{
-					{
-						Type:    v1.NodeInternalIP,
-						Address: "127.0.0.2",
-					},
-				},
-			},
-		},
-		{
-			ObjectMeta: metav1.ObjectMeta{
-				Name: "node-3",
-				Labels: map[string]string{
-					v1.LabelNodeExcludeBalancers: "true",
-				},
-			},
-			Status: v1.NodeStatus{
-				Addresses: []v1.NodeAddress{
-					{
-						Type:    v1.NodeInternalIP,
-						Address: "127.0.0.3",
-					},
-				},
-			},
-		},
-	}
-
-	if err = lb.UpdateLoadBalancer(t.Context(), "linodelb", svc, allExcludedNodes); err != nil {
-		t.Errorf("expected no error when all nodes are excluded, got %v", err)
-	}
-
-	// Verify nodes were updated correctly
-	nodeBalancerNodesAfterUpdate = getLatestNbNodesForService(t, client, svc, lb)
-	// Should have only 0 node (node-3), since all nodes are excluded
-	if len(nodeBalancerNodesAfterUpdate) != 0 {
-		t.Errorf("expected 0 nodes after update, got %d", len(nodeBalancerNodesAfterUpdate))
-	}
-}
-
 func testUpdateLoadBalancerNoNodes(t *testing.T, client *linodego.Client, _ *fakeAPI) {
 	t.Helper()