Skip to content

Conversation

@Andrews2024
Copy link
Contributor

@Andrews2024 Andrews2024 commented Feb 18, 2025

General:

Currently, route_controller manages and configures routes for all Linodes within a VPC if specified. This change adds the option to specify that CCM manages only nodes within a particular subnet or list of subnets.

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?

@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 74.46809% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (17a97be) to head (51d204e).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
cloud/linode/vpc.go 81.39% 6 Missing and 2 partials ⚠️
cloud/linode/cloud.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   71.63%   71.67%   +0.04%     
==========================================
  Files          14       14              
  Lines        2330     2376      +46     
==========================================
+ Hits         1669     1703      +34     
- Misses        506      515       +9     
- Partials      155      158       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Andrews2024 Andrews2024 merged commit ef75268 into main Feb 21, 2025
9 checks passed
@Andrews2024 Andrews2024 deleted the add-subnet-management branch February 21, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement for improvements in existing functionality in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants