Skip to content

[improvement] Allow setting vpcName(s) without enabling route controller #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulait merged 2 commits into from
Feb 20, 2025
Merged

[improvement] Allow setting vpcName(s) without enabling route controller #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e40778
Allow setting vpcName(s) without enabling route controller
cbbond Feb 20, 2025
fdf254e
Update docs
cbbond Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions deploy/chart/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,26 +44,34 @@ spec:
{{- with .Values.linodegoDebug }}
- --linodego-debug={{ . }}
{{- end }}
{{- if .Values.routeController }}
- --enable-route-controller=true
{{- if and .Values.routeController.vpcName .Values.routeController.vpcNames }}
{{- fail "Both vpcName and vpcNames are set. Please use only vpcNames." }}
{{- $vpcNames := .Values.vpcNames }}
{{- if and .Values.routeController .Values.routeController.vpcNames }}
{{- $vpcNames = .Values.routeController.vpcNames }}
{{- end }}
{{- if not (or .Values.routeController.vpcName .Values.routeController.vpcNames) }}
{{- fail "Neither vpcName nor vpcNames is set. Please set one of them." }}
{{- $vpcName := .Values.vpcName }}
{{- if and .Values.routeController .Values.routeController.vpcName }}
{{- $vpcName = .Values.routeController.vpcName }}
{{- end }}
{{- with .Values.routeController.vpcName }}
- --vpc-name={{ . }}
{{- if and $vpcName $vpcNames }}
{{- fail "Both vpcName and vpcNames are set. Please use only vpcNames." }}
{{- end }}
{{- with .Values.routeController.vpcNames }}
- --vpc-names={{ . }}
{{- if .Values.routeController }}
- --enable-route-controller=true
{{- if not (or $vpcName $vpcNames) }}
{{- fail "Neither vpcName nor vpcNames is set. Please set one of them." }}
{{- end }}
- --configure-cloud-routes={{ default true .Values.routeController.configureCloudRoutes }}
- --cluster-cidr={{ required "A valid .Values.routeController.clusterCIDR is required" .Values.routeController.clusterCIDR }}
{{- with .Values.routeController.routeReconciliationPeriod }}
- --route-reconciliation-period={{ . }}
{{- end }}
{{- end }}
{{- with $vpcNames }}
- --vpc-names={{ . }}
{{- end }}
{{- with $vpcName }}
- --vpc-name={{ . }}
{{- end }}
{{- if .Values.sharedIPLoadBalancing }}
{{- with .Values.sharedIPLoadBalancing.bgpNodeSelector }}
- --bgp-node-selector={{ . }}
Expand Down
4 changes: 4 additions & 0 deletions deploy/chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ tolerations:
# clusterCIDR: 10.0.0.0/8
# configureCloudRoutes: true

# vpcs that node internal IPs will be assigned from (not required if already specified in routeController)
# vpcName: <name of VPC> [Deprecated: use vpcNames instead]
# vpcNames: <comma separated list of vpc names>

# Enable Linode token health checker
# tokenHealthChecker: true

Expand Down
4 changes: 4 additions & 0 deletions docs/getting-started/helm-installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ routeController:
clusterCIDR: "10.0.0.0/8"
configureCloudRoutes: true

# Optional: Assign node internal IPs from VPCs without enabling route controller
# Not required if specified in routeController
vpcNames: "" # Comma separated VPC names

# Optional: Configure shared IP load balancing instead of NodeBalancers (requires Cilium CNI and BGP Control Plane enabled)
sharedIPLoadBalancing:
loadBalancerType: cilium-bgp
Expand Down
Loading