-
Notifications
You must be signed in to change notification settings - Fork 71
[feat] : enable nodeipamcontroller within CCM #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 72.98% 73.37% +0.38%
==========================================
Files 14 15 +1
Lines 2599 2670 +71
==========================================
+ Hits 1897 1959 +62
- Misses 537 544 +7
- Partials 165 167 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
78578d0 to
5d6cba9
Compare
5d6cba9 to
0719224
Compare
b31de9f to
fa3eeda
Compare
komer3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
08f517d to
4a622a2
Compare
* enable nodeipamcontroller within CCM * fix linting errors * add documentation * update docs, add kube-controller-manager flag which should not be set * fix helm chart templates
General:
This PR enables CCM to also do node IPAM management. To enable nodeipam-controller, one needs to set
--allocate-node-cidrsalong withcluster-cidrflag.Pull Request Guidelines: