Skip to content

Conversation

@rahulait
Copy link
Contributor

@rahulait rahulait commented Aug 6, 2025

General:

This PR adds new SLAAC ipv6 addr allocated to VPC interface as one of the address in k8s node's status. We list VPC specific ipv6 addrs first than any other ipv6 addr present on the node.

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@github-actions github-actions bot added the improvement for improvements in existing functionality in the changelog. label Aug 6, 2025
k8s.io/pod-security-admission => k8s.io/pod-security-admission v0.33.0
k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.33.0
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to upstream linodego when this PR is merged: linode/linodego#791

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 62.71186% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.12%. Comparing base (b0bf52f) to head (8f042b7).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
cloud/linode/instances.go 46.87% 14 Missing and 3 partials ⚠️
cloud/linode/vpc.go 81.48% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   72.44%   72.12%   -0.32%     
==========================================
  Files          19       19              
  Lines        3498     3544      +46     
==========================================
+ Hits         2534     2556      +22     
- Misses        733      751      +18     
- Partials      231      237       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@komer3 komer3 merged commit 9a6b3bc into main Aug 12, 2025
13 of 18 checks passed
@komer3 komer3 deleted the add-ipv6-slaac-addrs-to-status branch August 12, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement for improvements in existing functionality in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants