Skip to content

Conversation

@AshleyDumaine
Copy link
Contributor

This refactor is needed if we want to use the instance cache in the node IPAM controller since there would otherwise be a cyclic dependency.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 91.22807% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.17%. Comparing base (36df8ec) to head (d33b183).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cloud/linode/cloud.go 72.00% 4 Missing and 3 partials ⚠️
cloud/linode/cilium_loadbalancers.go 68.75% 3 Missing and 2 partials ⚠️
cloud/linode/utils/common.go 91.66% 2 Missing ⚠️
cloud/linode/loadbalancers.go 97.05% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #438   +/-   ##
=======================================
  Coverage   72.17%   72.17%           
=======================================
  Files          19       19           
  Lines        3551     3551           
=======================================
  Hits         2563     2563           
  Misses        751      751           
  Partials      237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AshleyDumaine AshleyDumaine changed the title [cleanup] refactor to move instance cache and options into their own packages [cleanup] refactoring packages Aug 15, 2025
@AshleyDumaine AshleyDumaine marked this pull request as ready for review August 15, 2025 15:06
@AshleyDumaine AshleyDumaine merged commit ee8fb73 into main Aug 15, 2025
9 checks passed
@AshleyDumaine AshleyDumaine deleted the package-refactor branch August 15, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants