Updated non-pointer omitempty fields to be pointers #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
force-pushed
the
TPT-3384-omitempty-pointers
branch
from
a2c54b3 to
a97530b
Compare
ezilber-akamai
requested review from
yec-akamai and
zliang-akamai
and removed request for
a team
ezilber-akamai
added
improvement
yec-akamai
approved these changes
Mar 3, 2025
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
Nice work! Tests all passed locally
zliang-akamai
requested review from
a team,
jriddle-linode and
ykim-akamai
and removed request for
a team
zliang-akamai
approved these changes
Mar 6, 2025
Member
zliang-akamai
left a comment
zliang-akamai
left a comment
There was a problem hiding this comment.
Others look great! Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Changed all non-pointer
omitemptyfields to be pointers for consistency.✔️ How to Test
The following test steps assume that you have pulled down this PR locally.
Unit Tests
make test-unitIntegration Tests
make test-int