Added support for Private Image Sharing #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
yec-akamai and
zliang-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Private Image Sharing functionality in the Linode Go client library. The implementation introduces image share groups with producer and consumer roles, allowing users to securely share private images.
- Implements complete Producer and Consumer APIs for image share groups including CRUD operations, member management, and image sharing
- Updates the Image struct to support image sharing metadata including vendor field changes to support nil values
- Adds comprehensive unit tests covering all new functionality with proper fixture data
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
images.go |
Updates Image struct to add ImageSharing fields and makes vendor/created_by fields nullable |
image_sharegroups_producer.go |
New file implementing producer-side image share group operations |
image_sharegroups_consumer.go |
New file implementing consumer-side image share group operations |
test/unit/images_test.go |
Updates existing tests for vendor field changes and adds new tests for private/shared images |
test/unit/image_sharegroups_producer_test.go |
New comprehensive test file for producer share group functionality |
test/unit/image_sharegroups_consumer_test.go |
New comprehensive test file for consumer share group functionality |
| Multiple fixture files | JSON test fixtures supporting the new functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zliang-akamai
approved these changes
Sep 16, 2025
yec-akamai
reviewed
Sep 18, 2025
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
Nice work! Just a few small things:
yec-akamai
approved these changes
Sep 19, 2025
Contributor
yec-akamai
left a comment
yec-akamai
left a comment
There was a problem hiding this comment.
Unit tests passed locally!
ezilber-akamai
merged commit e8cd264
into
linode:proj/private-image-sharing
10 checks passed
ezilber-akamai
added a commit
that referenced
this pull request
Nov 5, 2025
* Added support for Private Image Sharing (#800) * Added support for Private Image Sharing * Add missing endpoint * Fix lint * Addressed copilot suggestions * Reran monthly transfer fixture * Addressed PR comments * More PR comments * Added integration tests for Private Image Sharing (#831) * Fixes and added integration tests * Separate ImageShareEntry struct and address PR comments * Fix lint * Addressed PR comments * Reran GetMonthlyTransfer fixture * Remove LA notices * Copilot suggestions * Fixed TestInstance_GetMonthlyTransfer fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for new Private Image Sharing features and corresponding unit tests.
✔️ How to Test
make test-unit