Skip to content

Conversation

@zliang-akamai
Copy link
Member

📝 Description

The API doesn't accept interfaces key but linode_interfaces

Copilot AI review requested due to automatic review settings September 24, 2025 00:42
@zliang-akamai zliang-akamai requested a review from a team as a code owner September 24, 2025 00:42
@zliang-akamai zliang-akamai requested review from jriddle-linode and yec-akamai and removed request for a team September 24, 2025 00:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a firewall device type constant to match the API specification. The API expects linode_interface instead of interface for the firewall device type.

  • Updates the FirewallDeviceInterface constant value from "interface" to "linode_interface"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@zliang-akamai zliang-akamai added the breaking-change for breaking changes in the changelog. label Sep 25, 2025
@zliang-akamai zliang-akamai merged commit cee3651 into main Sep 25, 2025
10 checks passed
srbhaakamai pushed a commit to srbhaakamai/linodego that referenced this pull request Oct 4, 2025
srbhaakamai pushed a commit to srbhaakamai/linodego that referenced this pull request Oct 4, 2025
@zliang-akamai zliang-akamai deleted the zhiwei/fix-fw-device-interfaces branch November 6, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change for breaking changes in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants