Skip to content

Conversation

@zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Sep 24, 2025

📝 Description

There is a new rule in the formatter, and we will need to re-format everything to make it be compliant.

Also, disabling godoclint linter because we have many comments which are not compliant with it.

@zliang-akamai zliang-akamai requested a review from a team as a code owner September 24, 2025 00:45
@zliang-akamai zliang-akamai requested review from Copilot, ezilber-akamai and jriddle-linode and removed request for a team and Copilot September 24, 2025 00:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the codebase to comply with a new godoclint formatter rule by making return statements explicit across multiple Go files. The main change is replacing bare return statements with explicit return value specifications in functions that have named return parameters.

  • Added godoclint linter to the golangci-lint configuration
  • Updated all functions with named return parameters to use explicit return statements
  • Applied consistent formatting across the entire codebase

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.golangci.yml Added godoclint linter to enforce explicit return statements
volumes.go Made return statements explicit in GetUpdateOptions and GetCreateOptions methods
test/integration/integration_suite_test.go Made return statement explicit in testRecorder function
tags.go Made return statement explicit in GetCreateOptions method
profile_tokens.go Made return statements explicit in GetCreateOptions and GetUpdateOptions methods
profile_sshkeys.go Made return statements explicit in GetCreateOptions and GetUpdateOptions methods
profile.go Made return statement explicit in GetUpdateOptions method
network_ips.go Made return statement explicit in GetUpdateOptions method
lke_node_pools.go Made return statements explicit in GetCreateOptions and GetUpdateOptions methods
lke_clusters.go Made return statements explicit in GetCreateOptions and GetUpdateOptions methods
images.go Made return statement explicit in GetUpdateOptions method
domains.go Made return statement explicit in GetUpdateOptions method
domain_records.go Made return statement explicit in GetUpdateOptions method
client_monitor.go Made return statement explicit in NewMonitorClient function
client.go Made return statement explicit in NewClient function
account_users.go Made return statements explicit in GetCreateOptions and GetUpdateOptions methods
account_payments.go Made return statement explicit in GetCreateOptions method
account_oauth_client.go Made return statements explicit in GetCreateOptions and GetUpdateOptions methods
account_agreements.go Made return statement explicit in GetUpdateOptions method
account.go Made return statement explicit in GetUpdateOptions method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 34 out of 35 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this.

@zliang-akamai zliang-akamai merged commit 2ef37ae into linode:main Sep 24, 2025
10 checks passed
@zliang-akamai zliang-akamai added the repo-ci-improvement for improvements in the repository or CI workflow in the changelog. label Sep 24, 2025
srbhaakamai pushed a commit to srbhaakamai/linodego that referenced this pull request Oct 4, 2025
* Run golangci-lint fmt

* Fix go docs
srbhaakamai pushed a commit to srbhaakamai/linodego that referenced this pull request Oct 4, 2025
* Run golangci-lint fmt

* Fix go docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

repo-ci-improvement for improvements in the repository or CI workflow in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants