-
Notifications
You must be signed in to change notification settings - Fork 96
Format everything with golangci-lint
#830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the codebase to comply with a new godoclint formatter rule by making return statements explicit across multiple Go files. The main change is replacing bare return statements with explicit return value specifications in functions that have named return parameters.
- Added
godoclintlinter to the golangci-lint configuration - Updated all functions with named return parameters to use explicit return statements
- Applied consistent formatting across the entire codebase
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .golangci.yml | Added godoclint linter to enforce explicit return statements |
| volumes.go | Made return statements explicit in GetUpdateOptions and GetCreateOptions methods |
| test/integration/integration_suite_test.go | Made return statement explicit in testRecorder function |
| tags.go | Made return statement explicit in GetCreateOptions method |
| profile_tokens.go | Made return statements explicit in GetCreateOptions and GetUpdateOptions methods |
| profile_sshkeys.go | Made return statements explicit in GetCreateOptions and GetUpdateOptions methods |
| profile.go | Made return statement explicit in GetUpdateOptions method |
| network_ips.go | Made return statement explicit in GetUpdateOptions method |
| lke_node_pools.go | Made return statements explicit in GetCreateOptions and GetUpdateOptions methods |
| lke_clusters.go | Made return statements explicit in GetCreateOptions and GetUpdateOptions methods |
| images.go | Made return statement explicit in GetUpdateOptions method |
| domains.go | Made return statement explicit in GetUpdateOptions method |
| domain_records.go | Made return statement explicit in GetUpdateOptions method |
| client_monitor.go | Made return statement explicit in NewMonitorClient function |
| client.go | Made return statement explicit in NewClient function |
| account_users.go | Made return statements explicit in GetCreateOptions and GetUpdateOptions methods |
| account_payments.go | Made return statement explicit in GetCreateOptions method |
| account_oauth_client.go | Made return statements explicit in GetCreateOptions and GetUpdateOptions methods |
| account_agreements.go | Made return statement explicit in GetUpdateOptions method |
| account.go | Made return statement explicit in GetUpdateOptions method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8bc967a to
8a3b52e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 34 out of 35 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jriddle-linode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for doing this.
* Run golangci-lint fmt * Fix go docs
* Run golangci-lint fmt * Fix go docs
📝 Description
There is a new rule in the formatter, and we will need to re-format everything to make it be compliant.
Also, disabling
godoclintlinter because we have many comments which are not compliant with it.