TPT-4277: Implement support for Reserved IP for IPv4 by mgwoj · Pull Request #919 · linode/linodego

mgwoj · 2026-03-23T12:40:37Z

📝 Description

Complete the Go SDK (linodego) support for the Reserved IP feature. Several foundations are already in place; this story addresses the remaining gaps to bring the SDK fully in line with the API Specification.

✔️ How to Test

make test-unit
make TEST_ARGS="-run TestReservedIPAddress" test-int

As the API is not ready yet, there are only mocked integration tests.

Copilot

Pull request overview

Implements remaining Go SDK (linodego) support for the Reserved IPv4 feature to better align with the API spec, primarily by expanding reserved IP metadata support and adding unit coverage.

Changes:

Add reserved_ipv4_addresses support to tag creation and decode tagged objects of type reserved_ipv4_address.
Add reserved IP tags support plus new endpoints for updating a reserved IP and listing reserved IP types (pricing).
Add/extend unit tests and fixtures to validate request bodies and response decoding for reserved IP behavior.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`tags.go`	Adds tag create option for reserved IPv4 addresses and decodes tagged reserved IP objects.
`network_reserved_ips.go`	Adds tag support for reserving IPs, plus update + types-list endpoints and related models.
`instance_ips.go`	Extends `InstanceIP` with `tags` field to capture reserved IP tags.
`test/unit/tag_test.go`	Adds unit coverage for tag create with reserved IPv4 addresses and tagged-object decoding.
`test/unit/nodebalancer_test.go`	Adds request-body validation test for NodeBalancer create with `ipv4`.
`test/unit/network_reserved_ips_test.go`	Extends reserved IP tests to cover tags, update, and type listing.
`test/unit/network_ips_test.go`	Adds request-body validation for reserve allocation and combined RDNS+reserved update.
`test/unit/instance_test.go`	Adds request-body validation for instance create with explicit IPv4 list.
`test/unit/instance_ip_test.go`	Adds request-body validation for assigning a reserved IP to an instance.
`test/unit/fixtures/tagged_objects_reserved_ip_list.json`	Adds fixture for tagged reserved IPv4 address objects.
`test/unit/fixtures/network_reserved_ips_list.json`	Updates reserved IP list fixture with `reserved` and `tags`.
`test/unit/fixtures/network_reserved_ips_get.json`	Updates reserved IP get fixture with `reserved` and `tags`.
`test/unit/fixtures/network_reserved_ips.json`	Updates reserve-IP create fixture with `reserved` and `tags`.
`test/unit/fixtures/network_reserved_ip_update.json`	Adds fixture for reserved IP update response.
`test/unit/fixtures/network_reserved_ip_types_list.json`	Adds fixture for reserved IP types (pricing) list response.

Comments suppressed due to low confidence (1)

test/unit/fixtures/network_reserved_ips_list.json:26

This list fixture is missing the standard "page" field used by paginated list responses in this repo's fixtures. If this fixture is used with getPaginatedResults, pagination decoding may fail or behave inconsistently; add "page": 1 to match other list fixtures.

    ],
    "pages": 1,
    "results": 2
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lgarber-akamai

LGTM!

Copilot

Pull request overview

Copilot reviewed 27 out of 30 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-13T18:21:11Z

+// UpdateReservedIPOptions represents the options for updating a reserved IP address
+// NOTE: Reserved IP feature may not currently be available to all users.
+type UpdateReservedIPOptions struct {
+	Tags []string `json:"tags"`
 }


UpdateReservedIPOptions.Tags is a non-pointer slice without omitempty, so the zero value (nil) will marshal as "tags":null. If the API expects an array (even when clearing), this can cause request validation errors or unintended semantics. Consider using Tags *[]string json:"tags,omitempty"`` (consistent with other update options in the SDK) or validate that Tags is non-nil before issuing the PUT.

You can use omitzero instead of omitempty for any list to make sure empty slice are correctly marshalled.

Agree, this is the way to go

yec-akamai

Overall looks good. Is the security vulnerability related to this change?

mgwoj · 2026-04-15T11:08:25Z

Overall looks good. Is the security vulnerability related to this change?

No, it is not related at all

mawilk90 · 2026-04-28T13:53:48Z

+	defer teardown()
+
+	resIP, err := client.ReserveIPAddress(context.Background(), linodego.ReserveIPOptions{
+		Region: "us-east",


Hardcoded region, it will fail on DevCloud as there is only pl-labkrk-2 available. Maybe it is worth to use getRegionsWithCaps instead?

mawilk90 · 2026-04-28T13:54:05Z

+
+	// Reserve without tags first
+	resIP, err := client.ReserveIPAddress(context.Background(), linodego.ReserveIPOptions{
+		Region: "us-east",


Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

mgwoj requested a review from a team as a code owner March 23, 2026 12:40

mgwoj requested review from Copilot, vshanthe and yec-akamai and removed request for a team March 23, 2026 12:40

Copilot started reviewing on behalf of mgwoj March 23, 2026 12:41 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread network_reserved_ips.go Outdated

mgwoj changed the title ~~TPT-4277 Implement support for Reserved IP for IPv4~~ feat: TPT-4277 Implement support for Reserved IP for IPv4 Mar 23, 2026

mgwoj added the new-feature for new features in the changelog. label Mar 24, 2026

mgwoj changed the base branch from main to proj/reserved-ips March 24, 2026 13:45

mgwoj changed the title ~~feat: TPT-4277 Implement support for Reserved IP for IPv4~~ TPT-4277 Implement support for Reserved IP for IPv4 Mar 24, 2026

mgwoj changed the title ~~TPT-4277 Implement support for Reserved IP for IPv4~~ TPT-4277: Implement support for Reserved IP for IPv4 Mar 25, 2026

mgwoj requested review from lgarber-akamai and removed request for vshanthe March 25, 2026 10:46

lgarber-akamai approved these changes Apr 7, 2026

View reviewed changes

yec-akamai requested a review from Copilot April 13, 2026 18:14

Copilot started reviewing on behalf of yec-akamai April 13, 2026 18:15 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

yec-akamai reviewed Apr 13, 2026

View reviewed changes

mawilk90 reviewed Apr 28, 2026

View reviewed changes

mawilk90 mentioned this pull request May 4, 2026

TPT-4432: Review and implement integration tests for ReservedIPs for IPv4 #945

Draft

mgwoj and others added 6 commits May 6, 2026 16:14

TPT-4277 Implement support for Reserved IP for IPv4

ea7cfb3

Update network_reserved_ips.go

df79b83

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

TPT-4277 Implement support for Reserved IP for IPv4

f373747

TPT-4277 Implement support for Reserved IP for IPv4

9f697df

TPT-4277 Implement support for Reserved IP for IPv4

e0be620

TPT-4277: Implement support for Reserved IP for IPv4

1012645

mgwoj force-pushed the feature/TPT-4277-linodego-implement-support-for-reserved-ip-for-ipv4 branch from e150bbf to 1012645 Compare May 6, 2026 14:16

mgwoj requested a review from a team as a code owner May 6, 2026 14:16

mgwoj requested review from ckulinsk and Copilot and removed request for a team May 6, 2026 14:16

Copilot started reviewing on behalf of mgwoj May 6, 2026 14:17 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

Comment thread instance_ips.go

Comment thread tags.go

Comment thread test/integration/network_reserved_ips_test.go

mgwoj requested review from lgarber-akamai and mawilk90 May 6, 2026 14:26

TPT-4277: Implement support for Reserved IP for IPv4

20bd732

Conversation

mgwoj commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✔️ How to Test

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

lgarber-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgwoj Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

mgwoj commented Apr 15, 2026

Uh oh!

mawilk90 Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

mawilk90 Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mgwoj commented Mar 23, 2026 •

edited

Loading

yec-akamai Apr 13, 2026 •

edited

Loading