refactor: [M3-9265] - Migrate Drawer to ui package#11789
Merged
hasyed-akamai merged 20 commits intolinode:developfrom Mar 18, 2025
Merged
refactor: [M3-9265] - Migrate Drawer to ui package#11789hasyed-akamai merged 20 commits intolinode:developfrom
hasyed-akamai merged 20 commits intolinode:developfrom
Conversation
hasyed-akamai
force-pushed
the
M3-9265-migrate-drawer-to-ui
branch
from
3b98d1f to
5c305d0
Compare
hasyed-akamai
requested review from
harsh-akamai and
mjac0bs
and removed request for
a team
|
Coverage Report: ❌ |
pmakode-akamai
approved these changes
Mar 14, 2025
Contributor
pmakode-akamai
left a comment
pmakode-akamai
left a comment
There was a problem hiding this comment.
thanks @hasyed-akamai!
hasyed-akamai
force-pushed
the
M3-9265-migrate-drawer-to-ui
branch
from
c02af59 to
6b54634
Compare
pmakode-akamai
added
Add'tl Approval Needed
hkhalil-akamai
approved these changes
Mar 17, 2025
Contributor
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
There was a problem hiding this comment.
Thanks @hasyed-akamai!
hkhalil-akamai
added
Approved
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #29 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/firewalls/update-firewall.spec.ts" |
|||||||||||||||||
Contributor
Author
|
Merging - |
This was referenced Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Drawerfrommanagertoui📁Drawerthat allows consumers to pass aNotFoundcomponentDrawerwithNotFoundcomponent as a PropDrawerwithoutNotFoundcomponent as a PropPreview
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅