security: [M3-9540] - Remedy canvg dependency vulnerability
#11839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
added
the
Security
abailly-akamai
changed the title
canvg dependencycanvg dependency vulnerability
abailly-akamai
requested review from
dwiley-akamai and
hana-akamai
and removed request for
a team
|
Coverage Report: ✅ |
hana-akamai
approved these changes
Mar 14, 2025
Contributor
hana-akamai
left a comment
hana-akamai
left a comment
There was a problem hiding this comment.
Invoice and payment PDFs still working as expected ✅
dwiley-akamai
approved these changes
Mar 14, 2025
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
No adverse impacts on PDF generation observed ✅
bnussman-akamai
requested changes
Mar 14, 2025
Member
bnussman-akamai
left a comment
bnussman-akamai
left a comment
There was a problem hiding this comment.
Could we use resolutions to set a minimum version of canvg and leave the bundling alone?
"resolutions": {
"node-fetch": "^2.6.7",
"yaml": "^2.3.0",
"semver": "^7.5.2",
"cookie": "^0.7.0",
"nanoid": "^3.3.8",
"canvg": ">= 4.0.3"
},
github-project-automation
bot
moved this from Approved
to Changes Requested
in Cloud Manager
* Show the APL section only for standard cluster tiers * Added changeset: Disable APL for LKE-E clusters on create flow * WIP - poc for what disabled, rather than hidden, section would look like * Update with proposed UX changes * Update test coverage with mocked endpoints, UX changes * Tweak changeset * Update chip text size to small for consistency with other chips * Fix bug preventing 'no' button from being checked
…o file (linode#11853) * Fix GHA Cypress pipeline by using literal values in matrix * Redirect output to .env file
* change: [M3-9434] - Theme changes to create menu * update styles to CDS * Update CreateMenu.styles.ts * Added changeset: Update styles to CSD for create menu * Update packages/manager/src/features/TopMenu/CreateMenu/CreateMenu.styles.ts Co-authored-by: Hussain Khalil <[email protected]> * Disabling the custom font-weight eslint rule. --------- Co-authored-by: Hussain Khalil <[email protected]>
…cript (linode#11838) * fix: [M3-9459] - show details button misalignment for selected stackscript * Added changeset: show details button misalignment for selected stackscript * Remove StyledRootContainer ans use actionCell prop for alignment * Update changeset description
abailly-akamai
requested review from
jdamore-linode
and removed request for
a team
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #12 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
|||||||||||||||||
bnussman-akamai
approved these changes
Mar 18, 2025
github-project-automation
bot
moved this from Changes Requested
to Approved
in Cloud Manager
bnussman-akamai
added
Approved
This was referenced Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR fixes this dependabot vulnerability: https://github.com/linode/manager/security/dependabot/154
Changes 🔄
jspdfto3.0.1see: https://www.npmjs.com/package/jspdf
Preview 📷
There should be no visual or functional regressions from this PR
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅