change: [M3-9433] - Update styles to match CDS for Entity Header & Action Panel #11857

cpathipa · 2025-03-14T20:02:59Z

Description 📝

Update styles to match CDS for Entity Header & Action Panel.

Changes 🔄

List any change(s) relevant to the reviewer.

Removed minHeight 48 in Breadcrumb.styles.tsx
Removed unnecessary div wrapper in LinodesLanding.tsx
Update main content and LandingHeader spacing

Target release date 🗓️

Preview 📷

How to test 🧪

Verification steps

(How to verify changes)

Checkout the branch and verify figma changes for Entity Header and Action Panel

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All unit tests are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

This reverts commit b274baf.

…tion Panel.

…n Panel

github-actions · 2025-03-14T20:46:15Z

Coverage Report: ✅
Base Coverage: 79.96%
Current Coverage: 79.98%

hkhalil-akamai

✅ Entity header height is 34px
✅ Gap between action buttons is 24px

Thanks @cpathipa! 🚀

coliu-akamai

✅ entity header height
✅ gap between action buttons

Thanks Chandra! I did see a couple things that I have questions about - not sure what the guidelines are on them.

are there any guidelines for how much spacing there should be between banners and the entity header?

With the increased spacing below the entity header, the banner now feels a bit close

packages/manager/src/MainContent.tsx

coliu-akamai · 2025-03-21T17:53:04Z

packages/manager/src/components/LandingHeader/LandingHeader.tsx

+      sx={(theme) => ({
        alignItems: 'center',
        justifyContent: 'space-between',
+        marginBottom: theme.spacing(3),


Not sure what can be done about this if the spacing is part of the new redesign, but the increase in spacing feels a bit awkward for landing pages with tabs (maybe we just have to get used to it?)

prod this branch

cpathipa · 2025-03-21T18:08:02Z

@coliu-akamai Good call, I will reach out UX to get spacing details for banner.

packages/manager/src/MainContent.tsx

…r row elements in Linodes landing page.

…ernetesLanding page

…icing

…Image Pricing" This reverts commit db39606.

…velop

This reverts commit f17fc63, reversing changes made to 05d165b.

linode-gh-bot · 2025-04-24T23:31:16Z

Cloud Manager UI test results

🔺 6 failing tests on test run #28 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`6 Failing`	`552 Passing`	`5 Skipped`	`124m 19s`

Details

Failing Tests
	Spec	Test
❌	`user-verification-banner.spec.ts`	Cloud Manager Cypress Tests→User verification banner » User verification banner
❌	`user-verification-banner.spec.ts`	Cloud Manager Cypress Tests→User verification banner » User verification banner
❌	`user-verification-banner.spec.ts`	Cloud Manager Cypress Tests→User verification banner » User verification banner
❌	`email-bounce.spec.ts`	Cloud Manager Cypress Tests→Email bounce banners » Email bounce banners
❌	`email-bounce.spec.ts`	Cloud Manager Cypress Tests→Email bounce banners » Email bounce banners
❌	`token-expiration.spec.ts`	Cloud Manager Cypress Tests→Parent/Child token expiration » Parent/Child token expiration

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/account/user-verification-banner.spec.ts,cypress/e2e/core/account/email-bounce.spec.ts,cypress/e2e/core/parentChild/token-expiration.spec.ts"

cpathipa · 2025-04-25T03:04:19Z

Closing this PR in favor of #12108

cpathipa added 3 commits June 19, 2024 09:06

unit test coverage for HostNameTableCell

b274baf

Revert "unit test coverage for HostNameTableCell"

f958dab

This reverts commit b274baf.

change: [M3-9433] - update styles to match CDS for Entity Header & Ac…

e596431

…tion Panel.

cpathipa requested a review from a team as a code owner March 14, 2025 20:02

cpathipa requested review from cliu-akamai and hkhalil-akamai and removed request for a team March 14, 2025 20:03

github-project-automation bot added this to Cloud Manager Mar 14, 2025

github-project-automation bot moved this to Review in Cloud Manager Mar 14, 2025

cpathipa marked this pull request as draft March 14, 2025 20:03

cpathipa self-assigned this Mar 14, 2025

cpathipa added the Design Tokens Laying the groundwork for Design Tokens label Mar 14, 2025

cpathipa changed the title ~~change: [M3-9433] - Update styles to match CDS for Entity Header & Action Panel.~~ change: [M3-9433] - Update styles to match CDS for Entity Header & Action Panel Mar 14, 2025

cpathipa added 2 commits March 14, 2025 15:04

Added changeset: Update styles to match CDS for Entity Header & Actio…

88660d1

…n Panel

Merge branch 'develop' into M3-9433

8d78721

cpathipa added 2 commits March 17, 2025 10:17

Merge branch 'develop' into M3-9433

7a0cdbd

update layout spacing

cd9e1a7

cpathipa marked this pull request as ready for review March 17, 2025 19:48

Merge branch 'develop' into M3-9433

172165f

hkhalil-akamai approved these changes Mar 19, 2025

View reviewed changes

Merge branch 'develop' into M3-9433

e844303

cpathipa added the Add'tl Approval Needed Waiting on another approval! label Mar 19, 2025

Merge branch 'develop' into M3-9433

462b92d

coliu-akamai self-requested a review March 21, 2025 17:33

coliu-akamai approved these changes Mar 21, 2025

View reviewed changes

github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 21, 2025

hkhalil-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 25, 2025

Merge branch 'develop' into M3-9433

d12f946

hkhalil-akamai approved these changes Mar 27, 2025

View reviewed changes

packages/manager/src/MainContent.tsx Outdated Show resolved Hide resolved

cpathipa added 15 commits March 27, 2025 12:32

Add consistent spacing between GolabalNotifiacations section and othe…

5c5ee84

…r row elements in Linodes landing page.

Merge branch 'develop' into M3-9433

1b93bf1

Merge branch 'develop' into M3-9433

d733c34

Add consisten spacing between between banner and entity header in Kub…

90c6e52

…ernetesLanding page

Merge branch 'M3-9433' of github.com:cpathipa/manager into M3-9433

aacbcc0

Merge branch 'develop' into M3-9433

688f332

Merge branch 'develop' into M3-9433

777f71a

Merge branch 'develop' into M3-9433

8fbce09

Linodes landing page layout - group the notifications section

bd955f7

Merge remote-tracking branch 'origin/develop' into M3-9433

bb01ab6

Merge remote-tracking branch 'origin/develop' into M3-9433

b6144db

change: [M3-9433] - Image Service Gen2 GA: Update copy about Image Pr…

db39606

…icing

Revert "change: [M3-9433] - Image Service Gen2 GA: Update copy about …

27e9bb7

…Image Pricing" This reverts commit db39606.

Merge branch 'develop' of https://github.com/cpathipa/manager into de…

3c71bab

…velop

Merge branch 'develop' into M3-9433

05d165b

cpathipa requested a review from a team as a code owner April 24, 2025 14:35

cpathipa requested review from dmcintyr-akamai and removed request for a team April 24, 2025 14:35

cpathipa added 2 commits April 24, 2025 16:24

Merge remote-tracking branch 'origin/develop' into M3-9433

f17fc63

Revert "Merge remote-tracking branch 'origin/develop' into M3-9433"

4658d89

This reverts commit f17fc63, reversing changes made to 05d165b.

cpathipa marked this pull request as draft April 24, 2025 21:36

cpathipa added the Work in Progress label Apr 24, 2025

cpathipa closed this Apr 25, 2025

github-project-automation bot moved this from Approved to Merged in Cloud Manager Apr 25, 2025

This was referenced May 14, 2025

Release v1.142.0 - release → staging #12222

Merged

Release v1.142.0 – staging → master #12229

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

change: [M3-9433] - Update styles to match CDS for Entity Header & Action Panel #11857

change: [M3-9433] - Update styles to match CDS for Entity Header & Action Panel #11857

Uh oh!

cpathipa commented Mar 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 14, 2025 •

edited

Loading

Uh oh!

hkhalil-akamai left a comment •

edited

Loading

Uh oh!

coliu-akamai left a comment

Uh oh!

Uh oh!

coliu-akamai Mar 21, 2025

Uh oh!

cpathipa commented Mar 21, 2025

Uh oh!

Uh oh!

linode-gh-bot commented Apr 24, 2025

Uh oh!

cpathipa commented Apr 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

change: [M3-9433] - Update styles to match CDS for Entity Header & Action Panel #11857

change: [M3-9433] - Update styles to match CDS for Entity Header & Action Panel #11857

Uh oh!

Conversation

cpathipa commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

github-actions bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hkhalil-akamai left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coliu-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coliu-akamai Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

cpathipa commented Mar 21, 2025

Uh oh!

Uh oh!

linode-gh-bot commented Apr 24, 2025

Cloud Manager UI test results

🔺 6 failing tests on test run #28 ↗︎

Details

Troubleshooting

Uh oh!

cpathipa commented Apr 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cpathipa commented Mar 14, 2025 •

edited

Loading

github-actions bot commented Mar 14, 2025 •

edited

Loading

hkhalil-akamai left a comment •

edited

Loading