-
Notifications
You must be signed in to change notification settings - Fork 392
refactor: [M3-9542] - Migrate utilities to (at)linode/utilities package - Part 4
#11859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-9542] - Migrate utilities to (at)linode/utilities package - Part 4
#11859
Conversation
|
Coverage Report: ❌ |
hkhalil-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hasyed-akamai! All migrations appear correct.
I recommend merging develop before you merge the PR.
mjac0bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hasyed-akamai!
- Tests passing
- Code changes look correct
- Didn't see any regressions related to behavior related to utilities in the places I spot checked (Linodes, OBJ, LKE)
Happened to notice a regression with the SSH key drawer that is not related to these changes. The regression is in develop, but not staging or prod, so it's happened in the last couple of weeks. Mostly stating this here as a reminder to myself to create a ticket tomorrow. 😅 If you beat me to it, that's great too.
| Prod and Staging | Recent Regression - Develop |
|---|---|
![]() |
![]() |
Cloud Manager UI test results🎉 539 passing tests on test run #6 ↗︎
|


Description 📝
Move the utilities (with no external dependencies) & its associated tests to
@linode/utilitiespackage - Part 4Changes 🔄
@linode/utilitiespackageTarget release date 🗓️
N/A
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅