Skip to content

Conversation

@hasyed-akamai
Copy link
Contributor

@hasyed-akamai hasyed-akamai commented Mar 17, 2025

Description 📝

Move the utilities (with no external dependencies) & its associated tests to @linode/utilities package - Part 4

Changes 🔄

  • Moved
    • accountCapability
    • metadata
    • planNotices
    • regions
    • statMetrics
    • stringUtils
  • Moved associated tests to @linode/utilities package
  • Refactored some utils to fix the types

Target release date 🗓️

N/A

How to test 🧪

  • Confirm all checks pass
  • Ensure all unit tests pass in @linode/utilities
  • Confirm all the necessary imports are updated
  • Confirm nothing on CM breaks:
    • Ensure everything works as expected wherever the above utilities are used
    • Ensure all tests pass in CM
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@hasyed-akamai hasyed-akamai marked this pull request as ready for review March 17, 2025 11:31
@hasyed-akamai hasyed-akamai requested a review from a team as a code owner March 17, 2025 11:31
@hasyed-akamai hasyed-akamai requested review from harsh-akamai and mjac0bs and removed request for a team March 17, 2025 11:31
@github-actions
Copy link

Coverage Report:
Base Coverage: 79.96%
Current Coverage: 79.87%

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hasyed-akamai! All migrations appear correct.

I recommend merging develop before you merge the PR.

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hasyed-akamai!

  • Tests passing
  • Code changes look correct
  • Didn't see any regressions related to behavior related to utilities in the places I spot checked (Linodes, OBJ, LKE)

Happened to notice a regression with the SSH key drawer that is not related to these changes. The regression is in develop, but not staging or prod, so it's happened in the last couple of weeks. Mostly stating this here as a reminder to myself to create a ticket tomorrow. 😅 If you beat me to it, that's great too.

Prod and Staging Recent Regression - Develop
Screenshot 2025-03-18 at 6 56 35 PM Screenshot 2025-03-18 at 7 08 58 PM

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 19, 2025
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Mar 19, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 539 passing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing539 Passing3 Skipped104m 15s

@hasyed-akamai hasyed-akamai merged commit 290aff7 into linode:develop Mar 19, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Mar 19, 2025
@hasyed-akamai
Copy link
Contributor Author

Thanks @mjac0bs, for pointing this out i have created a ticket for the regression you have mentioned along with the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Modularization

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants