upcoming: [DI-23784] - Restrict actions in alerts action menu #11860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankita-akamai
requested review from
cpathipa and
pmakode-akamai
and removed request for
a team
ankita-akamai
requested review from
nikhagra-akamai,
santoshp210-akamai and
venkymano-akamai
Contributor
Author
|
Fixing some cypress type-check errors. |
nikhagra-akamai
suggested changes
Mar 17, 2025
packages/manager/src/features/CloudPulse/Alerts/Utils/AlertsActionMenu.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/Utils/AlertsActionMenu.ts
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from Review
to Changes Requested
in Cloud Manager
|
Coverage Report: ❌ |
ankita-akamai
requested review from
dmcintyr-akamai
and removed request for
a team
nikhagra-akamai
approved these changes
Mar 17, 2025
pmakode-akamai
approved these changes
Mar 17, 2025
Contributor
pmakode-akamai
left a comment
pmakode-akamai
left a comment
There was a problem hiding this comment.
thanks @ankita-akamai! Looks good ✅
packages/manager/src/features/CloudPulse/Alerts/AlertsListing/AlertTableRow.test.tsx
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from Changes Requested
to Approved
in Cloud Manager
dmcintyr-akamai
approved these changes
Mar 17, 2025
…e/restrictedAlertActions
…ogress' or 'failed'
venkymano-akamai
approved these changes
Mar 18, 2025
Collaborator
Cloud Manager UI test results🎉 539 passing tests on test run #6 ↗︎
|
Contributor
|
Merging this since checks pass, enough approvals, recently rebased and cypress passed |
This was referenced Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Restrict actions in alerts action menu based on alert status.
Changes 🔄
in progressorfailed.Target release date 🗓️
Next Release
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅