Skip to content

upcoming: [M3-9530] - Display interface type first in Linode Network IP Addresses table #11865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coliu-akamai merged 21 commits into from
Mar 27, 2025
Merged

upcoming: [M3-9530] - Display interface type first in Linode Network IP Addresses table #11865

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
72173ac
update ordering for IP table
coliu-akamai Mar 17, 2025
7ac594f
update todo comment
coliu-akamai Mar 17, 2025
80d1828
update aria label/id
coliu-akamai Mar 17, 2025
1a10c2c
update logic to make sortable
coliu-akamai Mar 17, 2025
9e842eb
Added changeset: Display interface type first in Linode Network IP Ad…
coliu-akamai Mar 17, 2025
c83dbd9
fix cypress
coliu-akamai Mar 18, 2025
73a3b9a
Merge branch 'develop' into m3-9530
coliu-akamai Mar 18, 2025
3cbef2d
Merge branch 'develop' into m3-9530
coliu-akamai Mar 20, 2025
81e4439
address feedback pt1
coliu-akamai Mar 20, 2025
9513b95
add preference key for IP table
coliu-akamai Mar 20, 2025
4779231
maybe this?
coliu-akamai Mar 20, 2025
fe1f0a3
or maybe this...
coliu-akamai Mar 20, 2025
71064a4
remove function map
coliu-akamai Mar 21, 2025
1128dda
add back in comment
coliu-akamai Mar 21, 2025
b32d897
argh
coliu-akamai Mar 21, 2025
ec2c254
Merge branch 'develop' into m3-9530
coliu-akamai Mar 24, 2025
bad89bc
lots of cleanup :))
coliu-akamai Mar 25, 2025
07623e2
change slaac for now
coliu-akamai Mar 25, 2025
c25237e
Merge branch 'develop' into m3-9530
coliu-akamai Mar 26, 2025
aacfedb
fix tests
coliu-akamai Mar 26, 2025
2696523
update changeset
coliu-akamai Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/LinodeIPAddressRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {
usePreferences,
useAllIPsQuery,
useLinodeIPsQuery,
useLinodeQuery,
useAllIPsQuery,
usePreferences,
} from '@linode/queries';
import { CircleProgress, Typography } from '@linode/ui';
import { styled } from '@mui/material/styles';
Expand All @@ -13,7 +13,9 @@ import { CopyTooltip } from 'src/components/CopyTooltip/CopyTooltip';
import { LinkButton } from 'src/components/LinkButton';
import { TableCell } from 'src/components/TableCell';
import { StyledTableRow } from 'src/features/Linodes/LinodeEntityDetail.styles';
import { useIsLinodeInterfacesEnabled } from 'src/utilities/linodes';

import { ipTypeToText } from './constants';
import { LinodeNetworkingActionMenu } from './LinodeNetworkingActionMenu';

import type { IPAddress, IPRange } from '@linode/api-v4';
Expand Down Expand Up @@ -53,6 +55,8 @@ export const LinodeIPAddressRow = (props: LinodeIPAddressRowProps) => {
type,
} = props;

const { isLinodeInterfacesEnabled } = useIsLinodeInterfacesEnabled();

const { data: ips } = useLinodeIPsQuery(linodeId);
const { data: maskSensitiveDataPreference } = usePreferences(
(preferences) => preferences?.maskSensitiveData
Expand All @@ -78,7 +82,7 @@ export const LinodeIPAddressRow = (props: LinodeIPAddressRowProps) => {
{!isVPCOnlyLinode && <StyledCopyToolTip text={address} />}
</TableCell>
<TableCell data-qa-ip-address sx={{ whiteSpace: 'nowrap' }}>
{type}
{isLinodeInterfacesEnabled ? ipTypeToText[type] : type}
</TableCell>
<TableCell>{gateway}</TableCell>
<TableCell>{subnetMask}</TableCell>
Expand Down
17 changes: 17 additions & 0 deletions packages/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import type { IPTypes } from './types';

// @TODO Linode Interfaces: when the Linode Interfaces feature flag is no longer needed,
// we can instead directly update IPTypes and relevant logic
export const ipTypeToText: Record<IPTypes, string> = {
'IPv4 – Private': 'Private – IPv4',
'IPv4 – Public': 'Public – IPv4',
'IPv4 – Reserved (private)': 'Reserved IPv4 (private)',
'IPv4 – Reserved (public)': 'Reserved IPv4 (public)',
'IPv4 – Shared': 'Shared – IPv4',
'IPv4 – VPC': 'VPC – IPv4',
'IPv4 – VPC – Range': 'VPC – Range – IPv4',
'IPv6 – Link Local': 'Link Local – IPv6',
'IPv6 – Range': 'Range – IPv6',
'IPv6 – SLAAC': 'Public - SLAAC – IPv6',
Copy link
Contributor Author

@coliu-akamai coliu-akamai Mar 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI mockups example:

(I've been trying to familiarize myself more with IPs/networking stuff, but there's still a lot I don't know - hopefully these are accurate!). For the UI, reading through IPs/networking stuff online and the API spec:

  • for Link Local IPs I haven't been able to find a big connection between them and public interfaces/internet. Also, when fetching IPs, i've been seeing that the public field in the returned object is false, so I haven't included 'Public' like in the UI mockup here
  • SLAAC addresses - the API spec notes "This is the main IPv6 address used to communicate over the public Internet and with other services in the same data center." The Public field is true, and the SLAAC address I receive when fetching IPs matches the SLAAC address in the public Linode Interface
  • for IPs not associated with interfaces like private IPs, I've still switched the order around for consistency (ex. 'Private' comes before IP type). (side note, iirc, private IPs are not allowed for new Linode Interfaces)

'VPC IPv4 – NAT': 'VPC NAT – IPv4',
};