Skip to content

Fix:[DI-24064] - Fix navigation for metrics and alerts under Monitor#11869

Merged
venkymano-akamai merged 8 commits intolinode:developfrom
ankita-akamai:feature/megaMenuFix
Mar 18, 2025
Merged

Fix:[DI-24064] - Fix navigation for metrics and alerts under Monitor#11869
venkymano-akamai merged 8 commits intolinode:developfrom
ankita-akamai:feature/megaMenuFix

Conversation

@ankita-akamai
Copy link
Contributor

@ankita-akamai ankita-akamai commented Mar 18, 2025

Description 📝

Hide or show 'Metrics' and 'Alerts' correctly based on all the relevant feature flags.

Changes 🔄

  • Update primary navigation file.

Target release date 🗓️

  • 25 March 2025

Preview 📷

here, aclp is enabled but none of the aclpalerting properties are true :

Before After
image image

How to test 🧪

Verification steps

(How to verify changes)

  • Try modifying the hide prop in primary navigation file - PrimaryNav.tsx. Do hit and trial with the feature flags, making them true and false to identify all scenarios when these menu items will show/not show.
    Possible Scenarios:
    • if aclp feature flag is disabled, none of the menu items - 'metrics' or 'alerts' will be visible.
    • if aclp feature is enabled but aclpAlerting feature flag has none of its properties true, only 'metrics' menu item will be visible, 'alerts' will not be visible.
    • if aclp feature is enabled and aclpAlerting feature has any one or all of its properties true, both 'metrics' and 'alerts' menu items will be visible.

Make use of the mocks -
image

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@ankita-akamai ankita-akamai requested a review from a team as a code owner March 18, 2025 07:25
@ankita-akamai ankita-akamai requested review from cpathipa and pmakode-akamai and removed request for a team March 18, 2025 07:25
@ankita-akamai ankita-akamai self-assigned this Mar 18, 2025
Copy link
Contributor

@nikhagra-akamai nikhagra-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add changeset

@ankita-akamai ankita-akamai changed the title upcoming:[DI-24064] - Fix navigation for metrics and alerts under Monitor Fix:[DI-24064] - Fix navigation for metrics and alerts under Monitor Mar 18, 2025
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 18, 2025
@github-actions
Copy link

github-actions bot commented Mar 18, 2025

Coverage Report:
Base Coverage: 80.08%
Current Coverage: 80.08%

Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the aclpAlerting feature flag is missing in DevTools. Could we add it so we can properly test it?

@ankita-akamai
Copy link
Contributor Author

ankita-akamai commented Mar 18, 2025

It looks like the aclpAlerting feature flag is missing in DevTools. Could we add it so we can properly test it?

@pmakode-akamai added the new feature flag - aclpAlerting in mocks , look for this label - CloudPulse Alerting

Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ankita-akamai! Looks good 👍 I've just added a comment to simplify the logic.

@pmakode-akamai pmakode-akamai added the Approved Multiple approvals and ready to merge! label Mar 18, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 539 passing tests on test run #7 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing539 Passing3 Skipped112m 9s

@venkymano-akamai venkymano-akamai merged commit bb95401 into linode:develop Mar 18, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants