Fix:[DI-24064] - Fix navigation for metrics and alerts under Monitor #11869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankita-akamai
requested review from
cpathipa and
pmakode-akamai
and removed request for
a team
nikhagra-akamai
approved these changes
Mar 18, 2025
Contributor
nikhagra-akamai
left a comment
nikhagra-akamai
left a comment
There was a problem hiding this comment.
please add changeset
ankita-akamai
changed the title
venkymano-akamai
approved these changes
Mar 18, 2025
|
Coverage Report: ✅ |
Contributor
pmakode-akamai
left a comment
pmakode-akamai
left a comment
There was a problem hiding this comment.
It looks like the aclpAlerting feature flag is missing in DevTools. Could we add it so we can properly test it?
Co-authored-by: Purvesh Makode <[email protected]>
Contributor
Author
@pmakode-akamai added the new feature flag - |
pmakode-akamai
approved these changes
Mar 18, 2025
Contributor
pmakode-akamai
left a comment
pmakode-akamai
left a comment
There was a problem hiding this comment.
thanks @ankita-akamai! Looks good 👍 I've just added a comment to simplify the logic.
Collaborator
Cloud Manager UI test results🎉 539 passing tests on test run #7 ↗︎
|
This was referenced Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Hide or show 'Metrics' and 'Alerts' correctly based on all the relevant feature flags.
Changes 🔄
Target release date 🗓️
Preview 📷
here, aclp is enabled but none of the aclpalerting properties are true :
How to test 🧪
Verification steps
(How to verify changes)
PrimaryNav.tsx. Do hit and trial with the feature flags, making them true and false to identify all scenarios when these menu items will show/not show.Possible Scenarios:
Make use of the mocks -
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅