feat: [UIE-8604] - IAM RBAC: remove toggle #11870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaleksee-akamai
requested review from
harsh-akamai and
mjac0bs
and removed request for
a team
|
Coverage Report: ✅ |
cpathipa
approved these changes
Mar 18, 2025
aaleksee-akamai
force-pushed
the
UIE-8604-drawer-create-user-remove-toggle
branch
from
14d8f80 to
232fba1
Compare
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/helpAndSupport/open-support-ticket.spec.ts" |
|||||||||||||||||
mjac0bs
approved these changes
Mar 18, 2025
Contributor
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Thanks @aaleksee-akamai - confirmed the change and I left two small bits of feedback.
packages/manager/src/features/IAM/Users/UsersTable/CreateUserDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/IAM/Users/UsersTable/CreateUserDrawer.tsx
Outdated
Show resolved
Hide resolved
mjac0bs
added
Approved
…default the user will have a limited access
aaleksee-akamai
force-pushed
the
UIE-8604-drawer-create-user-remove-toggle
branch
from
232fba1 to
0594cc3
Compare
This was referenced Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Remove the toggle in the
Add A Userdrawer, by default, the user will have limited accessChanges 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
(dev)
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Prerequisites
(How to setup test environment)
Add A UserbuttonReproduction steps
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅