Skip to content

Conversation

@pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Dec 31, 2025

Description 📝

Update the default sort of the plans when "All" is selected so that the plans descend from newest (G8) to oldest (G6)

Changes 🔄

  • Added client-side sorting for generational plans when "All" is selected to show plans from newest (G8) to oldest (G6)
  • Added a small getGenerationRank helper to support the ordering
  • Added unit tests for the helper

Scope 🚢

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

28 Jan 2026

Preview 📷

Before After
Screenshot 2025-12-31 at 3 22 51 PM Screenshot 2025-12-31 at 2 01 19 PM

How to test 🧪

Verification steps

  • Go to Create Linode -> Select a region -> Verify that the plan ordering works as expected
  • Go to Kubernetes / Create Cluster -> Select a region -> Verify that the plan ordering works as expected
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai self-assigned this Dec 31, 2025
@pmakode-akamai pmakode-akamai added the GCP Generational Compute Plans label Dec 31, 2025
@pmakode-akamai pmakode-akamai marked this pull request as ready for review December 31, 2025 09:19
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner December 31, 2025 09:19
@github-project-automation github-project-automation bot moved this from Review to Changes Requested in Cloud Manager Jan 2, 2026
@github-project-automation github-project-automation bot moved this from Changes Requested to Approved in Cloud Manager Jan 2, 2026
Copy link
Contributor

@grevanak-akamai grevanak-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmakode-akamai. Changes looks good to me!

@abailly-akamai
Copy link
Contributor

@pmakode-akamai - can you make sure the e2e failures are handled - not sure if you're behind on your branch but we'd want a clean slate to want to merge this. thx

@pmakode-akamai pmakode-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review Approved Multiple approvals and ready to merge! labels Jan 2, 2026
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner January 5, 2026 12:17
@pmakode-akamai pmakode-akamai requested review from jdamore-linode and removed request for a team January 5, 2026 12:17
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #9 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing869 Passing11 Skipped50m 21s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

@pmakode-akamai pmakode-akamai added Approved Multiple approvals and ready to merge! and removed SDET Approval Needed labels Jan 8, 2026
@cliu-akamai cliu-akamai self-requested a review January 8, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! GCP Generational Compute Plans

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

7 participants