-
Notifications
You must be signed in to change notification settings - Fork 391
upcoming: [UIE-9826] - Add reusable Product Selection Card component for Marketplace #13247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pmakode-akamai
wants to merge
12
commits into
linode:develop
Choose a base branch
from
pmakode-akamai:UIE-9826
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/manager/src/features/Marketplace/MarketplaceLanding/ProductSelectionCard.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Marketplace/MarketplaceLanding/ProductSelectionCard.tsx
Outdated
Show resolved
Hide resolved
| })} | ||
| variant="body1" | ||
| > | ||
| {truncate(description, 268)} |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's confirm with davyd if we need to truncate the description received from api here at UI.
Collaborator
Cloud Manager UI test results🎉 860 passing tests on test run #10 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add reusable Product Card component for Marketplace
Changes 🔄
MarketplaceLandingdirectoryScope 🚢
Target release date 🗓️
N/A
Preview 📷
Note
Logos shown in the preview are used only as examples for testing. The actual product logos will be provided by the API
How to test 🧪
Prerequisites
Enable MarketplaceV2 feature flag
Use the below example usage code in the
MarketplaceLandingcomponent for testing (use actual sample data or hardcoded values):Example usage code
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅