upcoming: [DI-29059] - Add delete action for user alert channels #13256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/delete_notification_channel_aclp
| data-qa-notification-channel-action-cell={`notification-channel-${id}`} | ||
| > | ||
| <NotificationChannelActionMenu | ||
| alertsCount={alerts.length} |
Contributor
There was a problem hiding this comment.
There is a dependency on this line. Yesterday I merged a PR to the release branch directly. #13254. It contains the changes regarding the latest API specification changes for Notification Channels. So this will break when the API changes.
So will hold off on merging this PR until the release is back-merged .
santoshp210-akamai
approved these changes
Jan 8, 2026
| React.useState<NotificationChannel | null>(null); | ||
| const [deleteState, setDeleteState] = React.useState({ | ||
| isDialogOpen: false, | ||
| isDeleting: false, |
Member
There was a problem hiding this comment.
Managing isDeleting in state is okay but may be unnecessary. The useDeleteNotificationChannel mutation hook will return an isPending value that could be used instead to track the loading state.
…e/delete_notification_channel_aclp
Collaborator
Cloud Manager UI test results🎉 855 passing tests on test run #4 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add delete action for user alert channels.
Changes 🔄
TypeToConfirmDialogcomponentuseDeleteNotificationChannel) with optimistic cache updatesScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
28 Jan 2026
Preview 📷
How to test 🧪
Verification steps
https://www.figma.com/design/26kXnWVNU5tK2xQdDdISuC/Custom-Alerts?node-id=7418-38705&t=YhSM9MnUVbY3hAMv-1
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅