Skip to content

Conversation

@mpolotsk-akamai
Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai commented Jan 13, 2026

Description 📝

This PR updates UI and text issues in Delegations.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Updated tooltip for 'Make A Payment' button
  • Fixed styling in the Default Entity Access table
  • Updated the confirmation message when unassigning a role in Default Roles
  • Changed 'Unassign Role' to 'Remove' in Default Roles Action menu
  • Fixed a styling issue in the Default Entity Access empty table

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Preview 📷

Before After
📷 📷

How to test 🧪

Prerequisites

(How to setup test environment)

  • use IAM account

Verification steps

(How to verify changes)

Tooltip message for disabled 'Make a Payment' button:

  1. Go to /billing as account_viewer or account_billing_viewer using account with linode billing method.
  2. Hover 'Make A Payment' button.
  3. Verify that The tooltip message is "You don't have permissions to make a payment..." .

Message in confirmation popup for unassign role:

  1. Go to /iam/roles/defaults/roles.
  2. Click action menu of any role.
  3. Click "Unassign Role" option.
  4. Verify that message in confirmation popup is "The role won’t be added to delegate users by default"

Text for option to remove role:

  1. Go to /iam/roles/defaults/roles
  2. Click action menu for any role.
  3. Verify that option to remove role with text "Remove" not "Unassign Role"

Table border issue after removing last entity in filtered list:

  1. Go to /iam/roles/defaults/entity-access
  2. Filter the table by entity type.
  3. Remove all of the entities in the filtered table.
  4. Verify that there are no table styling issue.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mpolotsk-akamai mpolotsk-akamai self-assigned this Jan 13, 2026
@mpolotsk-akamai mpolotsk-akamai force-pushed the UIE-9944-default-entity-table-fix branch from e87b26e to 80a2c9a Compare January 13, 2026 15:19
@mpolotsk-akamai mpolotsk-akamai added the IAM Delegation Implementing the new Parent/Child delegation UI label Jan 13, 2026
@mpolotsk-akamai mpolotsk-akamai force-pushed the UIE-9944-default-entity-table-fix branch from 80a2c9a to ff5bd21 Compare January 14, 2026 16:59
@mpolotsk-akamai mpolotsk-akamai marked this pull request as ready for review January 14, 2026 16:59
@mpolotsk-akamai mpolotsk-akamai requested review from a team as code owners January 14, 2026 17:00
@mpolotsk-akamai mpolotsk-akamai requested review from aaleksee-akamai, abailly-akamai and dmcintyr-akamai and removed request for a team January 14, 2026 17:00
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing854 Passing11 Skipped46m 5s

Details

Failing Tests
SpecTest
firewall-landing-page.spec.tsCloud Manager Cypress Tests→confirms Firewalls landing page empty state is shown when no Firewalls exist » lists all Firewalls

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/firewalls/firewall-landing-page.spec.ts"

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jan 15, 2026
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@mpolotsk-akamai mpolotsk-akamai merged commit 904a1b8 into linode:develop Jan 16, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IAM Delegation Implementing the new Parent/Child delegation UI

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

5 participants