-
Notifications
You must be signed in to change notification settings - Fork 392
UIE-9379: Implementing Add Pool functionality for PgBouncer #13276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
UIE-9379: Implementing Add Pool functionality for PgBouncer #13276
Conversation
3595b01 to
eceb323
Compare
| style={{ | ||
| marginTop: theme.spacingFunction(20), | ||
| }} | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm considering refactoring some of this. For example, this Box and the added margin is used to manage the space for each of the form fields.
Since a similar style is used throughout the connection pool drawer form, should I make this a reusable component? Alternatively, I could make it shared and move it outside of this file.
| }} | ||
| type="submit" | ||
| > | ||
| Add Pool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the submit button enabled since we take a similar approach in DatabaseCreate where it prevents submitting with UI validation and also displays any backend errors related to individual fields.
Does this approach make sense here are would an alternative approach be preferred?
| border: `1px solid ${theme.tokens.component.Select.Error.Border}`, | ||
| } | ||
| : undefined; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Select cds-web-components don't have an error state so this was added to give them the same error border that we see with the Linode components in their error state. In this case these are the Text Field components.
Cloud Manager UI test results🔺 2 failing tests on test run #9 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/images/search-images.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts" |
||||||||||||||||||||
Description 📝
This pull request is to implement the Add Pool functionality for PgBouncer. This will allow users to create new connection pools via a new drawer. Those connection pools will then be added to the connection pools table in the Networking tab.
Changes 🔄
List any change(s) relevant to the reviewer.
Add Poolbutton in the Database DetailsNetworkingtabManage PgBouncer Connection Poolssection to open an add connection pool drawer.Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Add Poolbutton gets enabled for postgresql database clusters, modify the mock database response by setting thedatabasestatus property in makeMockDatabase toactive.Verification steps
(How to verify changes)
General
Networkingtab of anactivePostgresql Database Clusterhttp://localhost:3000/databases/postgresql/1/networkingAdd Poolbutton in theManage PgBouncer Connection Poolssection to open theAdd a New Connection PooldrawerAdd PoolAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅