-
Notifications
You must be signed in to change notification settings - Fork 392
fix: [UIE-9987] - IAM Parent/Child - Various fixes to Parent Account Flow #13278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| return allChildAccounts; | ||
| } | ||
| return data?.pages.flatMap((page) => page.data); | ||
| }, [isIAMDelegationEnabled, searchQuery, allChildAccounts, data]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has just been lifted to the parent
| return allChildAccounts; | ||
| } | ||
| return data?.pages.flatMap((page) => page.data); | ||
| }, [isIAMDelegationEnabled, searchQuery, allChildAccounts, data]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not change any functionality in this file - just lifted queries and logic here to control the display of the search field
| // Invalidate all my delegated child accounts since delegation may have changed | ||
| queryClient.invalidateQueries({ | ||
| queryKey: delegationQueries.myDelegatedChildAccounts._ctx.all._def, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this, we had to refresh to get a fresh delegation state
Cloud Manager UI test results🎉 855 passing tests on test run #5 ↗︎
|
mpolotsk-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Description 📝
This PR improves the UX for the Parent Account users "Switch Account" and fixes a couple issues with the delegation feature.
Note
This PR only addressed the new Delegation feature. It should bring no regressions to existing Parent Account users
Changes 🔄
create_child_account_tokenisn't user facing, so we must allow the user to access the drawer. From there, they'll either see a list of Child Account they are allowed to switch to or no account)Scope 🚢
Upon production release, changes in this PR will be visible to:
How to test 🧪
Prerequisites
Have both legacy and IAM parent/child accounts
Verification steps
👉 IAM Reseller Account
/billing/iam/delegationsand add the current user to child delegation/iam/delegationsand remove the current user to child delegation👉 Legacy Parent/Child Account
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅