upcoming: [UIE-9741] - Implement Add Lock Modal.#13339
Merged
tanushree-akamai merged 8 commits intolinode:developfrom Feb 2, 2026
Merged
Conversation
…/unlocked irrespective of LKE association.
packages/manager/src/features/Linodes/LinodesDetail/LinodeLock/AddLockDialog.test.tsx
Outdated
Show resolved
Hide resolved
df1420d to
422b6b3
Compare
packages/manager/src/features/Linodes/LinodesDetail/LinodeLock/AddLockDialog.tsx
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the Add Lock modal feature, allowing users to apply locks to Linodes directly from the action menu. The implementation includes support for two lock types: preventing deletion only, or preventing deletion including attached resources.
Changes:
- Added
AddLockDialogcomponent with lock type selection UI and integration with the locks API - Connected the dialog to Linode action menus in both list and card views, as well as detail pages
- Implemented comprehensive unit tests for the dialog component
- Updated MSW mock handlers to properly validate and create locks with improved error handling
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/manager/src/features/Linodes/LinodesDetail/LinodeLock/AddLockDialog.tsx | New dialog component implementing the Add Lock UI with radio options for lock types |
| packages/manager/src/features/Linodes/LinodesDetail/LinodeLock/AddLockDialog.test.tsx | Comprehensive test suite covering dialog behavior, lock type selection, and API interactions |
| packages/manager/src/features/Linodes/LinodesLanding/LinodesLanding.tsx | Integrated Add Lock dialog with state management and handlers in the Linodes landing page |
| packages/manager/src/features/Linodes/LinodesDetail/LinodesDetailHeader/LinodeDetailHeader.tsx | Added Add Lock dialog to Linode detail header with corresponding state and handlers |
| packages/manager/src/features/Linodes/LinodesLanding/LinodeActionMenu/LinodeActionMenu.tsx | Enabled the Lock action to trigger the Add Lock dialog |
| packages/manager/src/features/Linodes/types.ts | Added 'add_lock' to DialogType union |
| packages/manager/src/mocks/presets/crud/handlers/locks.ts | Enhanced mock validation to return properly structured API errors |
| packages/manager/src/features/Linodes/LinodesLanding/ListView.tsx | Connected Add Lock handler to list view row actions |
| packages/manager/src/features/Linodes/LinodesLanding/CardView.tsx | Connected Add Lock handler to card view actions |
| packages/manager/.changeset/pr-13339-upcoming-features-1769622645991.md | Added changeset entry for the feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/manager/.changeset/pr-13339-upcoming-features-1769622645991.md
Outdated
Show resolved
Hide resolved
…645991.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
grevanak-akamai
approved these changes
Feb 2, 2026
harsh-akamai
approved these changes
Feb 2, 2026
Collaborator
Cloud Manager UI test results🎉 865 passing tests on test run #8 ↗︎
|
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR implements the Add Lock modal accessible from the Linode action menu.
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-01-28.at.11.15.07.PM.mov
How to test 🧪
Reproduction steps
[ "create_lock", "delete_lock" ]
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅