Skip to content

fix: [UIE-10329] - UpdateDelegationDrawer Follow up#13446

Open
abailly-akamai wants to merge 1 commit intolinode:developfrom
abailly-akamai:UIE-10329-fix
Open

fix: [UIE-10329] - UpdateDelegationDrawer Follow up#13446
abailly-akamai wants to merge 1 commit intolinode:developfrom
abailly-akamai:UIE-10329-fix

Conversation

@abailly-akamai
Copy link
Contributor

Description 📝

In #13441 I implemented an infinite query but omitted to handle the case where the user does a Select All, in which case we need to fetch all records.

We're still only fetching the first 25 users when opening the Drawer, so performance isn't affected. It's only if we decide to Select all of them that the expensive query happens, which is a decent workaround.

Changes 🔄

  • Add a new onSelectAllClick prop to our Autocomplete (not affecting current usage)
  • Fetch all users and select them on SelectAllClick

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Screen.Recording.2026-02-27.at.14.41.04.mov

How to test 🧪

Prerequisites

Have a large parent/child account (many users - ask for being added if not available)

Verification steps

  • navigate to /iam/delegations and Click Select ALL in the delegation Autocomplete
  • ✅ Confirm all users are fetched
  • ✅ Confirm all users are selected
  • ✅ Confirm "Deselect ALL" works as intended
  • ✅ Select ALL again and Click "Save" and confirm all users we attached to the delegation
  • ✅ Confirm no regression on the Autocomplete functionality
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai self-assigned this Feb 27, 2026
@abailly-akamai abailly-akamai added IAM (Identity & Access Management) IAM Delegation Implementing the new Parent/Child delegation UI labels Feb 27, 2026
@abailly-akamai abailly-akamai marked this pull request as ready for review February 27, 2026 13:42
@abailly-akamai abailly-akamai requested a review from a team as a code owner February 27, 2026 13:42
@abailly-akamai abailly-akamai requested review from aaleksee-akamai, kwojtowiakamai, mpolotsk-akamai and shagufa-akamai and removed request for a team February 27, 2026 13:42
}
label={'Delegate Users'}
loading={isFetching}
loading={isFetching || isFetchingAllUsers}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if you clear an input, then start typing - first, you'll see you have no options and only then a loading spinner and later a result

Copy link
Contributor

@aaleksee-akamai aaleksee-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IAM Delegation Implementing the new Parent/Child delegation UI IAM (Identity & Access Management)

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

3 participants