Skip to content

fix: [UIE-10244] - Connection Pools table page size #13448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hana-akamai wants to merge 3 commits into
base: develop
Choose a base branch
from
+14 −6
Open

fix: [UIE-10244] - Connection Pools table page size #13448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3ea1ab
add DEFAULT_PAGE_SIZES without infinity and update connection pools p…
hana-akamai Feb 27, 2026
9d633f0
refactor database landing table to use pageination footer page size c…
hana-akamai Feb 27, 2026
df38693
Added changeset: Database Connection Pools table page size
hana-akamai Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-13448-fixed-1772228313479.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

Database Connection Pools table page size ([#13448](https://github.com/linode/manager/pull/13448))
1 change: 1 addition & 0 deletions packages/manager/src/components/PaginationFooter/PaginationFooter.constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export const MIN_PAGE_SIZE = 25;

export const DEFAULT_PAGE_SIZES = [MIN_PAGE_SIZE, 50, 75, 100];
Copy link
Member

@bnussman-akamai bnussman-akamai Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be somewhere else? It's not obvious to me what the difference is between DEFAULT_PAGE_SIZES and PAGE_SIZES below

Copy link
Member

@bnussman-akamai bnussman-akamai Mar 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe PAGE_SIZES can be removed and we can just use DEFAULT_PAGE_SIZES only? From what I remember, we don't let people select Infinity/All anymore anyway

export const PAGE_SIZES = [MIN_PAGE_SIZE, 50, 75, 100, Infinity];
4 changes: 2 additions & 2 deletions ...ager/src/features/Databases/DatabaseDetail/DatabaseNetworking/DatabaseConnectionPools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ import React from 'react';

import { Link } from 'src/components/Link';
import {
DEFAULT_PAGE_SIZES,
MIN_PAGE_SIZE,
PAGE_SIZES,
} from 'src/components/PaginationFooter/PaginationFooter.constants';
import {
CONNECTION_POOL_LABEL_CELL_STYLES,
Expand Down Expand Up @@ -183,7 +183,7 @@ export const DatabaseConnectionPools = ({ database }: Props) => {
) => pagination.handlePageSizeChange(Number(e.detail.pageSize))}
page={pagination.page}
pageSize={pagination.pageSize}
pageSizes={PAGE_SIZES}
pageSizes={DEFAULT_PAGE_SIZES}
style={{
borderLeft: `1px solid ${theme.tokens.alias.Border.Normal}`,
borderRight: `1px solid ${theme.tokens.alias.Border.Normal}`,
Expand Down
8 changes: 5 additions & 3 deletions packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ import {
} from 'akamai-cds-react-components/Table';
import React from 'react';

import {
DEFAULT_PAGE_SIZES,
MIN_PAGE_SIZE,
} from 'src/components/PaginationFooter/PaginationFooter.constants';
import { TableRowEmpty } from 'src/components/TableRowEmpty/TableRowEmpty';
import { DatabaseSettingsDeleteClusterDialog } from 'src/features/Databases/DatabaseDetail/DatabaseSettings/DatabaseSettingsDeleteClusterDialog';
import DatabaseSettingsResetPasswordDialog from 'src/features/Databases/DatabaseDetail/DatabaseSettings/DatabaseSettingsResetPasswordDialog';
Expand Down Expand Up @@ -54,8 +58,6 @@ const DatabaseLandingTable = ({
preferenceKey,
queryParamsPrefix: dbPlatformType,
});
const PAGE_SIZES = [25, 50, 75, 100];
const MIN_PAGE_SIZE = 25;

const [selectedDatabase, setSelectedDatabase] =
React.useState<DatabaseInstance>({} as DatabaseInstance);
Expand Down Expand Up @@ -245,7 +247,7 @@ const DatabaseLandingTable = ({
) => pagination.handlePageSizeChange(Number(e.detail.pageSize))}
page={pagination.page}
pageSize={pagination.pageSize}
pageSizes={PAGE_SIZES}
pageSizes={DEFAULT_PAGE_SIZES}
style={{
borderLeft: `1px solid ${theme.tokens.alias.Border.Normal}`,
borderRight: `1px solid ${theme.tokens.alias.Border.Normal}`,
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/mocks/serverHandlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ const databases = [
}),

http.get('*/databases/postgresql/instances/:id/connection-pools', () => {
const connectionPools = databaseConnectionPoolFactory.buildList(5);
const connectionPools = databaseConnectionPoolFactory.buildList(50);
// For mocking error response
// return HttpResponse.json({ errors: [{ reason: 'Unable to retrieve connection pools' }] }, { status: 400 });
return HttpResponse.json(makeResourcePage(connectionPools));
Expand Down