feat [OCA-1671]: Remove Line Break in Cluster Cards#13510
feat [OCA-1671]: Remove Line Break in Cluster Cards#13510n0vabyte wants to merge 10 commits intolinode:developfrom
Conversation
| display: 'flex', | ||
| font: theme.font.bold, | ||
| fontSize: '1rem', | ||
| wordBreak: 'break-word', |
There was a problem hiding this comment.
Probably unlikely, but, because we are changing this style here at the UI component level, it may cause regressions elsewhere in the app.
There was a problem hiding this comment.
Totally - I tried looking to see if there were any other places where this is referenced and I couldn't find anything.
|
@bnussman-akamai I think we might want to use a different tag for the "Marketplace" to avoid cross-reference to the Sales/Marketing one. Think what we are going with now is "Quick Deploy Apps". Just a thought. |
|
Any updates on this @bnussman-akamai? |
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Verification steps ✅
Code review ✅
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
|
This has test failing. Now we're transitioning CM repo to gitsource. Please re-raise the PR there. |
4 participants
Description 📝
Cluster quick deploy apps display name look broken because line break is being added. This PR removes the line-break being loaded to provide a more consistent app name display. This appears to only happen with quick deploy apps with the
CLUSTERchip.Removes old references to "Marketplace" at the bottom of the app's info slider page
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Next cloud release
Preview 📷
How to test 🧪
Verification steps
CLUSTERchip is not displaying name with line-breakAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅